Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(can we) delete inst/readmes/ folder? #151

Open
stefaniebutland opened this issue Jan 8, 2025 · 1 comment
Open

(can we) delete inst/readmes/ folder? #151

stefaniebutland opened this issue Jan 8, 2025 · 1 comment
Labels
question Further information is requested

Comments

@stefaniebutland
Copy link
Member

It looks to me like the /readmes folder containing only one file - https://github.com/Openscapes/kyber/blob/main/inst/readmes/readme-template.Rmd - is not used by kyber. Can I delete it after PR #150 is merged?

Its last commit was 2 yrs ago by @jules32. I have copied any relevant content to https://github.com/Openscapes/kyber/blob/main/inst/rmarkdown/templates/openscapes-cohort-readme/skeleton/skeleton.Rmd and made further updates in PR #150. This is the file kyber uses to make cohort README.

@stefaniebutland stefaniebutland added the question Further information is requested label Jan 8, 2025
@ateucher
Copy link
Contributor

ateucher commented Jan 9, 2025

I think so, I don't see any reference to it either

stefaniebutland added a commit that referenced this issue Jan 10, 2025
Addressing issue #151. Is it safe to delete the inst/readmes dir? Tagging Julie and Sean for review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants