Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vehicle horn to BaseMoving #854

Open
tbleher opened this issue Feb 18, 2025 · 1 comment
Open

Add vehicle horn to BaseMoving #854

tbleher opened this issue Feb 18, 2025 · 1 comment

Comments

@tbleher
Copy link
Contributor

tbleher commented Feb 18, 2025

Describe the feature

Currently OSI does not describe use of the vehicle horn. This makes it impossible to use OSI for simulation of the surrounding noise.
Also agent models should be able to react to the use of the vehicle horn (as they do in reality - people react to the use of the vehicle horn).

Describe the solution you would like

BaseMoving should have a new bool field that is true when the vehicle horn is active.

Describe alternatives you have considered

None

Describe the backwards compatibility

New field - fully backward compatible.

Additional context

None

@thomassedlmayer
Copy link
Contributor

Maybe we should add it to VehicleClassification instead of BaseMoving?

BaseMoving is used for all kinds of moving objects (pedestrians, animals). VehicleClassification also contains things like light states.

I suggest using a wrapper similar to LightState, which could wrap various auditory properties (like engine noise/pedestrian warning sounds or whatever, and probably even corresponding volumes). This wrapper could then contain a bool field for the horn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants