Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSI ModelReference String #835

Open
jdsika opened this issue Oct 16, 2024 · 4 comments
Open

OSI ModelReference String #835

jdsika opened this issue Oct 16, 2024 · 4 comments
Assignees
Labels
HelpWanted I have tried my best - please help me!

Comments

@jdsika
Copy link
Contributor

jdsika commented Oct 16, 2024

Would it be a sesitive next step to define the ModelReference String as URI?

@jdsika jdsika added the HelpWanted I have tried my best - please help me! label Oct 16, 2024
@ClemensLinnhoff
Copy link
Contributor

In my personal opinion, yes. But I don't know if this would break backwardcompatibility, because previously it could be however people want.

@pmai
Copy link
Contributor

pmai commented Oct 30, 2024

I don't think it makes sense to do so, especially as long as no common definition of file formats has happened, and as different use cases have different requirements:

  • In some use cases the model reference is just a key that the receiver will know what to do with (e.g. it has built-in models that the references apply to); while of course URIs can be invented for this purpose, they would just mislead other receivers into believing they have semantics that they don't.
  • Even in cases where the sender would know how to locate the models via URIs, there are additional conventions that would need to be defined (i.e. what schemes are allowed, are relative URIs allowed/required), so that a receiver can then use the URIs reliably to locate the same models. And even then as long as there is no agreement on the file formats that should be supported, this still all boils down to individual agreements to make this work.

So as long as this is the case I do not see the point (i.e. the portability enhancement) that mandating URIs would bring. Of course anyone who wants to use URIs is allowed to do so anyways.

@ClemensLinnhoff
Copy link
Contributor

I agree.
But I think this is something that we can define in OpenMATERIAL for example. So if an OSI message is used in combination with OpenMATERIAL compliant 3D assets, the model_reference shall have a certain form.

@ClemensLinnhoff
Copy link
Contributor

I added an issue for this in OpenMATERIAL: asam-ev/OpenMATERIAL-3D#160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HelpWanted I have tried my best - please help me!
Projects
None yet
Development

No branches or pull requests

3 participants