Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"rest_get" and "mpirc" snippets provided in incorrect contexts #695

Open
dessina-devasia opened this issue Mar 19, 2024 · 4 comments
Open

"rest_get" and "mpirc" snippets provided in incorrect contexts #695

dessina-devasia opened this issue Mar 19, 2024 · 4 comments
Assignees
@turkeylurkey
Labels
bug Something isn't working medium priority should-fix
Milestone
Next

Comments

@dessina-devasia
Copy link
Contributor

dessina-devasia commented Mar 19, 2024 •
edited by turkeylurkey
Loading

During the FVT for version 24.0.3-SNAPSHOT on a Windows 11 environment, an issue was encountered with the identification of 'rest_get' and 'mpirc' snippets under certain conditions in Java files. Specifically, the issue arises in the following scenario:

In the space before a class declaration (empty space).
For reference, I've attached a screenshot below showcasing the same.

image

This issue has been reported to lsp4mp as issue eclipse-lsp4mp/lsp4mp#402
@TrevCraw TrevCraw changed the title Issue Identifying rest_get and mpirc Snippets in Specific Java File Scenario During 24.0.3 FVT Testing on Windows 11 "rest_get" and "mpirc" snippets provided in incorrect contexts Mar 27, 2024
@TrevCraw TrevCraw added bug Something isn't working should-fix labels Mar 27, 2024
@TrevCraw
Copy link
Contributor

Most likely an issue with LSP4MP incorrectly setting the context value for these snippets

@TrevCraw TrevCraw added this to the 24.0.7 milestone May 17, 2024
@TrevCraw TrevCraw modified the milestones: 24.0.7, Next Jun 27, 2024
@turkeylurkey turkeylurkey self-assigned this Oct 30, 2024
@turkeylurkey
Copy link
Member

mpirc is the only snippet marked as a field and rest_get is the only snippet marked as a method. LSP4MP needs to improve its handling of these two types of snippets.

@turkeylurkey turkeylurkey moved this from Prioritized to In Progress in Open Liberty Developer Experience Nov 5, 2024
@turkeylurkey
Copy link
Member

Created a pull request in lsp4mp eclipse-lsp4mp/lsp4mp#476

@turkeylurkey
Copy link
Member

We are discussing what to do in lsp4mp, one alternate proposal suggested.

@turkeylurkey turkeylurkey modified the milestones: 24.0.12, Next Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turkeylurkey turkeylurkey

Labels
bug Something isn't working medium priority should-fix
Projects
Open Liberty Developer Experience
Status: In Progress
Milestone
Next
Development

No branches or pull requests
3 participants
@TrevCraw @turkeylurkey @dessina-devasia