Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IntelliJ IDEA 2025.1 #1233

Open
TrevCraw opened this issue Jan 16, 2025 · 6 comments
Open

Support IntelliJ IDEA 2025.1 #1233

TrevCraw opened this issue Jan 16, 2025 · 6 comments
Assignees
Milestone

Comments

@TrevCraw
Copy link
Contributor

Investigate to find any issues with LTI integration for IntelliJ IDEA 2025.1. Make sure to perform both automated and manual testing. Open new issues and track them here.

The 2025.1 EAP build can be found here: https://www.jetbrains.com/idea/nextversion/

@anusreelakshmi934
Copy link
Contributor

I started investigating this issue and ran a build with ideTargetVersion=251.14649.49. During this build, a few tests failed with the error: java.lang.UnsupportedOperationException: Unsupported IntelliJ version: 2025.1 EAP. This occurred because the following code is currently hardcoded in our implementation:

if (intellijVersion.startsWith("2024.2")) {
menuAction2 = menuAction2024_2;
} else if (intellijVersion.startsWith("2024.3")) {
menuAction2 = menuAction2024_3;
}

So while migrating to the latest version changes need to be done in this.

@anusreelakshmi934
Copy link
Contributor

I reviewed the JetBrains documentation, but it doesn't provide much additional information at this time. It’s possible they may update it with more details later.

@anusreelakshmi934 anusreelakshmi934 moved this from New Issues to In Progress in Open Liberty Developer Experience Jan 21, 2025
@dessina-devasia
Copy link
Contributor

I started investigating this issue and ran a build with ideTargetVersion=251.14649.49. During this build, a few tests failed with the error: java.lang.UnsupportedOperationException: Unsupported IntelliJ version: 2025.1 EAP. This occurred because the following code is currently hardcoded in our implementation:

if (intellijVersion.startsWith("2024.2")) {
menuAction2 = menuAction2024_2;
} else if (intellijVersion.startsWith("2024.3")) {
menuAction2 = menuAction2024_3;
}

So while migrating to the latest version changes need to be done in this.

@anusreelakshmi934 We probably need to provide menuAction support for version 2025.1 as well. For now, we must support both the current and previous menu actions. Starting with future releases (from 2025.2 onward), we can support only the latest menu action and remove the conditions. In the meantime, we need to update the condition as follows:

if (intellijVersion.startsWith("2024.2")) {
 menuAction2 = menuAction2024_2;
 } else if (intellijVersion.startsWith("2024.3") || intellijVersion.startsWith("2025.1")) {
 menuAction2 = menuAction2024_3;
}

@TrevCraw @turkeylurkey Could you please comment on this?

@anusreelakshmi934
Copy link
Contributor

@dessina-devasia I've updated our code to include the condition check for 2025.1. Here is the GHA build, which is still in progress. However, when I tested it locally, the previously failing tests passed.

@anusreelakshmi934
Copy link
Contributor

We are also encountering a SocketException while running the ide:

Image

@anusreelakshmi934
Copy link
Contributor

anusreelakshmi934 commented Jan 23, 2025

We are also encountering some intermittent issues in some tests. They are having

initializationError FAILED
    com.intellij.remoterobot.utils.WaitForConditionTimeoutException: Exceeded timeout (PT30S) for condition function (The project tree on the "File or Project" dialog did not show the set project) 

In this build both GradleSingleModMPSIDProjectTest and MavenSingleModMPSIDProjectTest has failed while in this only MavenSingleModMPSIDProjectTest failed. So this has an irregular pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants