Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constants for string literals throughout the UI tests. #1153

Open
mrglavas opened this issue Dec 4, 2024 · 0 comments · May be fixed by #1199
Open

Add constants for string literals throughout the UI tests. #1153

mrglavas opened this issue Dec 4, 2024 · 0 comments · May be fixed by #1199
Assignees
@anusreelakshmi934
Labels
automated tests clean-up
Milestone
CI/CD Jan

Comments

@mrglavas
Copy link
Contributor

mrglavas commented Dec 4, 2024

While reviewing #1145 I noticed the UI tests have many string literals that are duplicated like "Compact Mode" and "Close All Tabs". These really should be moved to constants to make the code more maintainable.
@mrglavas mrglavas added documentation Improvements or additions to documentation clean-up automated tests and removed documentation Improvements or additions to documentation labels Dec 4, 2024
@mrglavas mrglavas added this to the CI/CD Next milestone Dec 4, 2024
@anusreelakshmi934 anusreelakshmi934 self-assigned this Dec 17, 2024
@anusreelakshmi934 anusreelakshmi934 linked a pull request Dec 18, 2024 that will close this issue
Open
@anusreelakshmi934 anusreelakshmi934 moved this from New Issues to In Review in Open Liberty Developer Experience Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anusreelakshmi934 anusreelakshmi934

Labels
automated tests clean-up
Projects
Open Liberty Developer Experience
Status: In Review
Milestone
CI/CD Jan
Development

Successfully merging a pull request may close this issue.

Add constants for string literals in UI test classes anusreelakshmi934/liberty-tools-intellij
2 participants
@mrglavas @anusreelakshmi934