-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling and status tracking for GitHub actions #2462
Comments
@stuartc , @midigofrank , this needs to be spiked |
Hmm, I think we will need more than just
We can use webhooks to know when the github workflow run finishes. https://docs.github.com/en/webhooks/webhook-events-and-payloads#workflow_run |
@theroinaochieng why is this marked as blocked? I have created an issue for showing and alerting users when Sync breaks here: #2965 Happy to chat about this. |
cc; @midigofrank please can you share why this is blocked? |
My bad @christad92, I thought I already added it here. In order to use these webhooks, we need a way to identify the github workflow run and be able to match it with a user in lightning.
The problem is that when initiating a sync, we don't get anything back that is related to the This issue is blocked because there is no clear way to go around this. We should set aside some time to do an analysis of what is possible/not possible |
Our current design of the GitHub sync is such that when a user triggers the sync there is no way for them to know if it is successful. When this is successful, it is great but when there is an error and the sync is not successful, it can be catastrophic.
When a sync operation fails, we should trigger the failure alert as well so that they receive an email that it failed. In the future, we should allow them to see a list of GitHub syncs on their projects and the status of those operations.
Notify users when GitHub sync failure
Show users the last time a project synced on the project list page
Please do not remove the last updated field.
The text was updated successfully, but these errors were encountered: