Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vocab_mapper: don't log input data #161

Open
josephjclark opened this issue Jan 27, 2025 · 0 comments
Open

vocab_mapper: don't log input data #161

josephjclark opened this issue Jan 27, 2025 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

The vocab mapper currently logs the raw input data. But this means that if we submit any user's API keys, they're freely available to anyone reading the server logs.

Solutions:

  • don't log raw input, only log formatted input
  • redact any sensitive values in the input

Maybe a wider point here is: perhaps the Apollo server should have a system for automatically logging all raw inputs for data purposes. We can use an input.credentials object and only log the keys of that, rather than the values. Or log partial values actually, the last 5 characters or so. That way, individual services don't have to worry about this stuff, and the official guideline can be "don't ever log raw input data".

It would be useful debugging to see a hint of the API key's value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant