Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vocab mapper: allow all keys to be passed by the client #152

Open
josephjclark opened this issue Jan 24, 2025 · 0 comments
Open

vocab mapper: allow all keys to be passed by the client #152

josephjclark opened this issue Jan 24, 2025 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

The vocab mapper currently expects an anthropic API key to be passed by the client request.

We should also enable the pinecone and openai keys to be passed in the request object too. It sort of looks like this is supposed to work in the vocab_mapper main function, but while the keys are tested they aren't fed through to the vectorstore.

Now, in the long run, it makes sense for client to send their anthropic and openai keys directly, because that basically let them pay for themselves.

Pinecone is a bit harder to justify, because the pinecone API key needs to give access to the embeddings database which loaded the datasets. In the short-medium term WE own this an WE control the embeddings, so this has to come from the Apollo server.

But enabling the pinecone key to be passed would let us work around #151 and get the demo working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant