Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to has model #2001

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Conversation

LillyG901
Copy link
Contributor

@LillyG901 LillyG901 commented Dec 14, 2024

Summary of the discussion

See #2000

Type of change (CHANGELOG.md)

Update

  • add comment to has model

Workflow checklist

Automation

Closes #2000

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo.omn changes the oeo.omn -module label Dec 14, 2024
@LillyG901 LillyG901 marked this pull request as ready for review January 13, 2025 10:52
@stap-m
Copy link
Contributor

stap-m commented Jan 14, 2025

Seems like you did not add the comment itself... :) The right file to add the comment is oeo-import-edits btw, since the relation is imported by RO.

@madbkr
Copy link
Contributor

madbkr commented Jan 15, 2025

I can't find the actual comment either - I'll come back for a review once you made the change that @stap-m suggested.

stap-m and others added 2 commits January 16, 2025 12:34
@LillyG901
Copy link
Contributor Author

That's interesting, thanks for pointing it out. It should now be added to the correct file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if the change in this file is still a relict of the first attempt or if this is supposed to be here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is generated automatically.

Copy link
Contributor

@madbkr madbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused by the workflow files in this commit but I assume that was to fix the bug we had before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is generated automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo.omn changes the oeo.omn -module
Projects
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

Bugfix: textual definition of has model does not match axioms
4 participants