Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we still need economic value? #1917

Closed
stap-m opened this issue Sep 12, 2024 · 5 comments · Fixed by #1931
Closed

do we still need economic value? #1917

stap-m opened this issue Sep 12, 2024 · 5 comments · Fixed by #1931

Comments

@stap-m
Copy link
Contributor

stap-m commented Sep 12, 2024

With the introduction of relational quantity value in #1878 and a consequent application of fraction value, the class economic value as it currently exists, looses its children.
Do we need it anyway?
Is there a criterion that we could apply to make it an equivalent class that is inferred?

Originally posted by @stap-m in #1875 (comment)

Do we need it anyway?

The definition is rather arbitrary anyway: An economic value is a quantity value that is economically relevant. Any of our quantity values can be economically relevant in one way or another.

Originally posted by @l-emele in #1875 (comment)

@stap-m stap-m changed the title do we still need economic value? do we still need economic value? Sep 12, 2024
@stap-m
Copy link
Contributor Author

stap-m commented Sep 12, 2024

We could deprecate economic value, if we don't need it. But I see the following implications:
This would affect the object property economic value of. It could be replaced by quantity value of.
Furthermore, all usages that go beyond "subclass of" axioms should be checked and adjusted.

@l-emele
Copy link
Contributor

l-emele commented Sep 13, 2024

We also have has economic value.

I would argue that if economic value does not really makes sense with its current definition, then economic value of and has economic value do not make sense either, so we should deprecate or re-define all three of them.

@han-f: Do you remember whether there was an important use case to introduce economic value or the two object properties?

@han-f
Copy link
Contributor

han-f commented Sep 19, 2024

No, I do not recall. Isn't quantity value sufficient also for "economic" things? It may be that the value paid for something is different than the economic value applied to it by an agent, but I am not sure anymore whether we need this distinction.

@l-emele
Copy link
Contributor

l-emele commented Sep 19, 2024

If we agree that we do not need this class anymore, then should deprecate it and not simply delete it as this class was potentially already used externally. Inspired by https://wiki.geneontology.org/Obsoleting_an_Existing_Ontology_Term I suggest:

  • label: obsolete economic value
  • definition: OBSOLETE: An economic value is a quantity value that is economically relevant.
  • comment: This term was made obsolete because its definition is rather vague and thus not useful.
  • Add annotation owl:deprecated: true
  • Remove all axioms

For the object properties the same, respectively with the comment: As the class economic value was deprecated this object property became obsolete, too.

@stap-m
Copy link
Contributor Author

stap-m commented Sep 19, 2024

From oeo-dev 87:

  • Gibt es noch Anwendungsfälle für economic value? --> keine bekannt
  • @stap-m verschickt mail an oeo-dev und implementiert
  • CHANGELOG: add deprecated category (new)

@l-emele l-emele added this to the oeo-release-2.5.0 milestone Sep 20, 2024
stap-m added a commit that referenced this issue Sep 23, 2024
stap-m added a commit that referenced this issue Sep 23, 2024
stap-m added a commit that referenced this issue Sep 23, 2024
stap-m added a commit that referenced this issue Sep 23, 2024
stap-m added a commit that referenced this issue Sep 23, 2024
stap-m added a commit that referenced this issue Sep 23, 2024
…ion-of-economic-value

make economic value obsolete #1917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants