-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor request parsing #45
Comments
@kotfic I replaced the GaiaRequestParser with a slightly modified version of your custom_json_deserialize JSON function in the postgis branch, and modified the request JSON accordingly. Example:
|
@mbertrand sorry for the turn around time on review. Looked at deserialize function in the postgis branch and it looks good to me. Once that's in i think we can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@aashish24 This is in regards to your suggestion yesterday to refactor how/where request parsing takes place, could you provide some more details? I think you mentioned having request JSON parsed by the process object itself? But the request parser in it's current state is responsible for actually creating the process.
Here is an example of the current request parser being used in Girder:
The text was updated successfully, but these errors were encountered: