From 4ead82ca2c47186d047870a6e9c6ff845e1af790 Mon Sep 17 00:00:00 2001 From: Song Meo Date: Fri, 3 May 2024 15:56:33 +0300 Subject: [PATCH 1/2] #323: change local_node_id from 0 to absent --- pycyphal/_version.py | 2 +- pycyphal/transport/udp/_udp.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pycyphal/_version.py b/pycyphal/_version.py index 6cea18d8..4a7bff54 100644 --- a/pycyphal/_version.py +++ b/pycyphal/_version.py @@ -1 +1 @@ -__version__ = "1.18.0" +__version__ = "1.18.1" diff --git a/pycyphal/transport/udp/_udp.py b/pycyphal/transport/udp/_udp.py index 20965946..85d1991a 100644 --- a/pycyphal/transport/udp/_udp.py +++ b/pycyphal/transport/udp/_udp.py @@ -64,7 +64,7 @@ class UDPTransport(pycyphal.transport.Transport): def __init__( self, local_ip_address: IPAddress | str, - local_node_id: typing.Optional[int] = 0, + local_node_id: typing.Optional[int], *, # The following parameters are keyword-only. mtu: int = MTU_DEFAULT, service_transfer_multiplier: int = 1, From 7ff7ac24b7fa942cd39e12d354e0b6c3ad0fd2e1 Mon Sep 17 00:00:00 2001 From: Song Meo Date: Thu, 9 May 2024 23:19:51 +0300 Subject: [PATCH 2/2] fix test failing after updating variable --- tests/application/node.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/application/node.py b/tests/application/node.py index 4010d2d1..6968add0 100644 --- a/tests/application/node.py +++ b/tests/application/node.py @@ -23,7 +23,7 @@ async def _unittest_slow_node(compiled: typing.List[pycyphal.dsdl.GeneratedPacka asyncio.get_running_loop().slow_callback_duration = 3.0 assert compiled - remote_pres = Presentation(UDPTransport("127.1.1.1")) + remote_pres = Presentation(UDPTransport("127.1.1.1", None)) remote_hb_sub = remote_pres.make_subscriber_with_fixed_subject_id(Heartbeat_1) remote_info_cln = remote_pres.make_client_with_fixed_service_id(GetInfo_1, 258)