Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --reproducible option to prevent generation of any volatile metadata #324

Open
Willmac16 opened this issue Jan 12, 2024 · 4 comments
Open

Add --reproducible option to prevent generation of any volatile metadata #324

Willmac16 opened this issue Jan 12, 2024 · 4 comments
Assignees
@thirtytwobits
Milestone
3.0

Comments

@Willmac16
Copy link

Willmac16 commented Jan 12, 2024 •
edited
Loading

Making this because I saw the TODO in the C++ template, and I want to have a place to ask questions while I work on this.

for the c++ template would the hidden fields just be:

  • Generator
  • Source file
  • Generated at
  • Platform

And all the static asserts would need their paths cleaned
@thirtytwobits
Copy link
Member

Reversing the logic here in my fix to --embed-auditing-info since it normally desirable to make code generation idempotent.

@thirtytwobits thirtytwobits self-assigned this Mar 7, 2024
thirtytwobits added a commit that referenced this issue Mar 8, 2024
@thirtytwobits
Issue #324 and #318 fixes
fb67b72 
Three things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. general cleanup based on linter feedback as I encountered it.
thirtytwobits added a commit that referenced this issue Mar 9, 2024
@thirtytwobits
Issue #324 and #318 fixes
a19e027 
Three things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. general cleanup based on linter feedback as I encountered it.
thirtytwobits added a commit that referenced this issue Mar 9, 2024
@thirtytwobits
Issue #324 and #318 fixes
b190599 
Things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. fixup copyrights to be dateless (in library)
4. general cleanup based on linter feedback as I encountered it.
5. modernized pytest dependencies
6. updated pydsdl dependency to use the latest
7. updated development environment detils (e.g. newer toxic container,
   improvements to coverage configuration and cSpell, switch to pylint, etc.)
8.various documentation improvements and cleanup
thirtytwobits added a commit that referenced this issue Mar 11, 2024
@thirtytwobits
Issue #324 and #318 fixes
2ee6092 
Things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. fixup copyrights to be dateless (in library)
4. general cleanup based on linter feedback as I encountered it.
5. modernized pytest dependencies
6. updated pydsdl dependency to use the latest
7. updated development environment detils (e.g. newer toxic container,
   improvements to coverage configuration and cSpell, switch to pylint, etc.)
8.various documentation improvements and cleanup
thirtytwobits added a commit that referenced this issue Mar 11, 2024
@thirtytwobits
Issue #324 and #318 fixes
571b2ee 
Things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. fixup copyrights to be dateless (in library)
4. general cleanup based on linter feedback as I encountered it.
5. modernized pytest dependencies
6. updated pydsdl dependency to use the latest
7. updated development environment detils (e.g. newer toxic container,
   improvements to coverage configuration and cSpell, switch to pylint, etc.)
8.various documentation improvements and cleanup
thirtytwobits added a commit that referenced this issue Mar 12, 2024
@thirtytwobits
Issue #324 and #318 fixes
84d2530 
Things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. fixup copyrights to be dateless (in library)
4. general cleanup based on linter feedback as I encountered it.
5. modernized pytest dependencies
6. updated pydsdl dependency to use the latest
7. updated development environment detils (e.g. newer toxic container,
   improvements to coverage configuration and cSpell, switch to pylint, etc.)
8.various documentation improvements and cleanup
thirtytwobits added a commit that referenced this issue Mar 12, 2024
@thirtytwobits
Issue #324 and #318 fixes
2f6d2c3 
Things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. fixup copyrights to be dateless (in library)
4. general cleanup based on linter feedback as I encountered it.
5. modernized pytest dependencies
6. updated pydsdl dependency to use the latest
7. updated development environment detils (e.g. newer toxic container,
   improvements to coverage configuration and cSpell, switch to pylint, etc.)
8.various documentation improvements and cleanup
thirtytwobits added a commit that referenced this issue Mar 12, 2024
@thirtytwobits
Issue #324 and #318 fixes
a17f312 
Things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. fixup copyrights to be dateless (in library)
4. general cleanup based on linter feedback as I encountered it.
5. modernized pytest dependencies
6. updated pydsdl dependency to use the latest
7. updated development environment detils (e.g. newer toxic container,
   improvements to coverage configuration and cSpell, switch to pylint, etc.)
8.various documentation improvements and cleanup
thirtytwobits added a commit that referenced this issue Mar 12, 2024
@thirtytwobits
Issue #324 and #318 fixes
8790ff9 
Things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. fixup copyrights to be dateless (in library)
4. general cleanup based on linter feedback as I encountered it.
5. modernized pytest dependencies
6. updated pydsdl dependency to use the latest
7. updated development environment detils (e.g. newer toxic container,
   improvements to coverage configuration and cSpell, switch to pylint, etc.)
8.various documentation improvements and cleanup
thirtytwobits added a commit that referenced this issue Mar 13, 2024
@thirtytwobits
Issue #324 and #318 fixes
5f739e2 
Things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. fixup copyrights to be dateless (in library)
4. general cleanup based on linter feedback as I encountered it.
5. modernized pytest dependencies
6. updated pydsdl dependency to use the latest
7. updated development environment detils (e.g. newer toxic container,
   improvements to coverage configuration and cSpell, switch to pylint, etc.)
8.various documentation improvements and cleanup
thirtytwobits added a commit that referenced this issue Mar 13, 2024
@thirtytwobits
Issue #324 and #318 fixes
8cffe45 
Things in this PR
1. fix issue #324 to add `--embed-auditing-info` and to remove, by default, all ephemeral meta data from the built-in templates.
2. fix issue #318 by adding `pascal` to the reserved word list for C
3. fixup copyrights to be dateless (in library)
4. general cleanup based on linter feedback as I encountered it.
5. modernized pytest dependencies
6. updated pydsdl dependency to use the latest
7. updated development environment detils (e.g. newer toxic container,
   improvements to coverage configuration and cSpell, switch to pylint, etc.)
8.various documentation improvements and cleanup
@thirtytwobits thirtytwobits reopened this Mar 22, 2024
@aentinger
Copy link

Without going through all those commits now - is the NNVG build output reproducible now?

@thirtytwobits
Copy link
Member

It should/will be. I haven't had time to do the pypi release though. Wanted to get some burn in on my end before pulling that trigger and closing these bugs.

@aentinger
Copy link

Thank you for the clarification 🙇 .

thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Jun 28, 2024
@thirtytwobits
Making generated code reproducable
1766e4d 
Support for --embed-auditing-info was added several changes ago. This last change completes OpenCyphal#324 for when this option is not provided.
@thirtytwobits thirtytwobits added this to the 3.0 milestone Jul 25, 2024
thirtytwobits added a commit to thirtytwobits/nunavut that referenced this issue Jul 26, 2024
@thirtytwobits
Preview of Nunavut 3.0 changes
d6b13e7 
Support for --embed-auditing-info was added several changes ago. This last change completes OpenCyphal#324 for when this option is not provided.

Progress on depfiles

First step towards OpenCyphal#334

Progress: legacy mode isolated.

Progress. Legacy should remain functional here. New APIs not working yet.

Progress on integrating the new generator method with the CLI

Legacy tests are green

Buncha progress but blocked on pydsdl OpenCyphal#109

Progress on untangling support from pod

All python tests green after ResourceType refactor stage 1

C++ stable.

Progress on testing new modes

Small refactor of environment object

Most mypy warnings clear

Getting docs fixed up

Coverage up

Changing to omit-deprecated

Checkpoint for depfile support

More Progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thirtytwobits thirtytwobits

Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@aentinger @thirtytwobits @Willmac16