-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update task manager #397
feat: update task manager #397
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
src/cmd_task_manager.h
Outdated
namespace pikiwidb { | ||
|
||
|
||
class TaskPool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要这样命名,class 的命名应该和文件名一致
CmdTaskManager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我理解这个 TaskPool 是不是可以不需要,直接继承 EventLoop 就可以了
src/cmd_task_manager.cc
Outdated
if (worker_loops_.empty()) | ||
return BaseLoop(); | ||
|
||
auto& loop = worker_loops_[current_work_loop_++ % worker_loops_.size()]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current_work_loop_++ % worker_loops_.size() 不要这么写,这种写法可读性太差了
src/base_task.h
Outdated
|
||
namespace pikiwidb { | ||
|
||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
移除无用代码
New Commit: add brpc_redis and base_task
|
No description provided.