Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

编译使用submodule master分支,而不是使用依赖的released版本,稳定性上不觉得是问题吗? #390

Closed
toontong opened this issue Nov 7, 2018 · 2 comments

Comments

@toontong
Copy link

toontong commented Nov 7, 2018

编译使用submodule master分支,而不是使用依赖的released版本,稳定性上不觉得是问题吗?

问题1:
Makefile中执行 git submodule update, 取的是所有依赖在github上master分支代码。
如facebook/rocksdb,master代码天天变,不使用最新released版本,编译出来的稳定性有瘾患。
如参考rocksdb做法,其rocksdb/third-party/目录,是copy过来第3方源码过来了;
其它方法,指定submodule tag,并在README上标示,如何换依赖库的版本。

问题2:
released页面中,下载的原码是没法编译的,因为没有submodule 信息。没法拉依赖代码下来。

@fancy-rabbit
Copy link
Collaborator

问题1,.gitmodules里有引用版本的。
问题2,用二进制好了。想编译的话clone代码并且checkout到对应的tag。

@purplegrape
Copy link

问题是submodule 不完整,额外还依赖gflags、snappy,以及gperftools的特定版本

@Axlgrep Axlgrep closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants