Support Pub/Sub #207
Merged
Support Pub/Sub #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KernelMaker
reviewed
Nov 14, 2017
include/pika_client_conn.h
Outdated
| @@ -21,10 +21,17 @@ class PikaClientConn: public pink::RedisConn { | |||
| void* worker_specific_data); | |||
| virtual ~PikaClientConn() {} | |||
| virtual int DealMessage(); | |||
| bool PubSub() { | |||
KernelMaker
reviewed
Nov 14, 2017
include/pika_client_conn.h
Outdated
| bool PubSub() { | ||
| return is_pubsub_; | ||
| } | ||
| void SetPubSub(bool is_pubsub) { |
KernelMaker
reviewed
Nov 14, 2017
include/pika_server.h
Outdated
| std::vector<std::pair<std::string, int>>* result); | ||
|
|
||
| void PubSubChannels(const std::string& pattern, | ||
| std::vector<std::string >* result); |
KernelMaker
reviewed
Nov 14, 2017
src/pika_client_conn.cc
Outdated
| auth_stat_.Init(); | ||
| } | ||
|
|
||
| std::string ConstructPubSubResp(const std::string& cmd, |
There was a problem hiding this comment.
pink里是redis conn 里构造Publish的响应消息
这里是pika conn构造sub unsub的响应消息
publish的响应消息由pink发送
sub unsub的响应消息由pika这层发送
KernelMaker
reviewed
Nov 14, 2017
src/pika_client_conn.cc
Outdated
| std::vector<std::pair<std::string, int>> result; | ||
| g_pika_server->Subscribe(conn, channels, false, &result); | ||
| this->SetPubSub(true); | ||
| return ConstructPubSubResp(kCmdNameSubscribe, result); |
There was a problem hiding this comment.
要么就去掉pink里的ConstructPubSubResp，都交给pika来构造，按理说pink的pubsub不应该有协议相关的东西
There was a problem hiding this comment.
嗯 Pubsub没有与协议相关的东西 调用的是redis conn里面的接口构造publish的消息
baotiao
reviewed
Nov 14, 2017
include/pika_pubsub.h
Outdated
| * pubsub | ||
| */ | ||
| class PublishCmd : public Cmd { | ||
| public: |
src/pika_client_conn.cc
Outdated
| const std::vector<std::pair<std::string, int>>& result) { | ||
| std::stringstream resp; | ||
| if (result.size() == 0) { | ||
| resp << "*3\r\n" << "$" << cmd.length() << "\r\n" << cmd << |
There was a problem hiding this comment.
改成用 printf 或者 snprintf, 别用iostream
Closed
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* add pubsub interface * modify client connection flag * bugfix * bugfix * bugfix * add pubsub() * type * bugfix channels name * format * optimize code * bugfix interface * bugfix * bugfix * optimize code * bugfix * bugfix * fix conflict * fix conflict * modify header file
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* add pubsub interface * modify client connection flag * bugfix * bugfix * bugfix * add pubsub() * type * bugfix channels name * format * optimize code * bugfix interface * bugfix * bugfix * optimize code * bugfix * bugfix * fix conflict * fix conflict * modify header file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.