Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move streams implementation to storage layer. #2242

Merged
merged 14 commits into from
Feb 1, 2024
Merged
Prev Previous commit
Next Next commit
fix: build problem on ubuntu.
KKorpse committed Jan 29, 2024
commit 7ea89dbb8e57280598d175f649e485e67852f446
3 changes: 1 addition & 2 deletions src/storage/src/redis_streams.h
Original file line number Diff line number Diff line change
@@ -9,7 +9,6 @@
#include <cstddef>
#include <cstdint>
#include <string>
#include "include/storage/storage.h"
#include "pika_stream_meta_value.h"
#include "pika_stream_types.h"
#include "rocksdb/options.h"
@@ -136,7 +135,7 @@ class RedisStreams : public Redis {
Status XRange(const Slice& key, const StreamScanArgs& args, std::vector<IdMessage>& id_messages);
Status XRevrange(const Slice& key, const StreamScanArgs& args, std::vector<IdMessage>& id_messages);
Status XLen(const Slice& key, int32_t& len);
Status XRead(const StreamReadGroupReadArgs& args, std::vector<std::vector<storage::IdMessage>>& results,
Status XRead(const StreamReadGroupReadArgs& args, std::vector<std::vector<IdMessage>>& results,
std::vector<std::string>& reserved_keys);
Status XInfo(const Slice& key, StreamInfoResult& result);