Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context sensitive alert for missing data (with refresh button) #231

Closed
soxofaan opened this issue Jan 12, 2022 · 6 comments
Closed

Context sensitive alert for missing data (with refresh button) #231

soxofaan opened this issue Jan 12, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@soxofaan
Copy link
Member

from https://github.com/openEOPlatform/architecture-docs/issues/179#issuecomment-1011249020 :

The web editor refreshes jobs every two minutes. So for a retry to get all jobs you either need to wait for two minutes or login again.

Two minutes sometimes feels like ages 😛 and having to re-login when you refresh the page is frustrating behavior.
Maybe add a button to refresh the job listing manually (optionally guarding users to press it too frequently)?

@m-mohr
Copy link
Member

m-mohr commented Jan 12, 2022

We had one in the past, but it didn't feel right as it doesn't really fit in as a workaround for a back-end issue you rarely need. Thus, we removed it. So for simplicity, I'll not re-implement it until there is major demand for it.

(Also, this is only an issue right now because you can't switch between tabs as the Editor also reloads on every "tab" switch, but openEO Platform is simply too limited right now. Once File Upload or Secondary Web Services are implemented (which is in the pipeline), the issue can be "worked around" without logging in again. )

@m-mohr m-mohr closed this as completed Jan 12, 2022
@m-mohr m-mohr added the wontfix This will not be worked on label Jan 12, 2022
@m-mohr m-mohr changed the title button to refresh job listing Context sensitive button to fetch missing data Jan 12, 2022
@m-mohr m-mohr reopened this Jan 12, 2022
@m-mohr
Copy link
Member

m-mohr commented Jan 12, 2022

Re-opening with a different idea for two issues that recently came up:

  1. If discovery data is completely missing (recently came up several times on the VITO back-end), show a button to retry loading the data. We could show a warning instead of the list of processes/collections/...

    [ The collections are missing due to a server issue | Retry ]

  2. Show a refresh button, but only if federation:missing contains at least one item (recently came up several times on the openEO Platform backend). This can be part of the planned "alert" that is shown when a back-end is missing in the results (see Implement support for the Federation Extension #230). So something like:

    [ The list is incomplete as data from one back-end is missing: ABC | Reload | Close ]

So in contrast to the original proposal, this is context-sensitive and only shows these buttons/alerts when there's a real need for it.

@m-mohr m-mohr changed the title Context sensitive button to fetch missing data Context sensitive alert/button to fetch missing data Jan 12, 2022
@m-mohr m-mohr changed the title Context sensitive alert/button to fetch missing data Context sensitive alert for missing data (with refresh button) Jan 12, 2022
@m-mohr m-mohr added enhancement New feature or request and removed wontfix This will not be worked on labels Jan 12, 2022
@m-mohr m-mohr added this to the v0.11 milestone Jan 12, 2022
@m-mohr m-mohr self-assigned this Jan 12, 2022
@soxofaan
Copy link
Member Author

So in contrast to the original proposal, this is context-sensitive and only shows these buttons/alerts when there's a real need for it.

That would indeed cover the problem with partial/failing responses from back-ends.

But as a user the 2 minute poll interval sometimes feels frustratingly slow. Is it possible to make that interval context-sensitive/dynamic? E.g. If you just submitted a job, poll one or two times with 15s interval so you don't have to wait needlessly 2 minutes to see that your job failed for a stupid user error? Or when you detect that the webeditor is unused in a background tab, increase the poll interval to 5 (or longer) minutes?

@m-mohr
Copy link
Member

m-mohr commented Jan 14, 2022

But with the proposal above you could simply click refresh, so I don't really understand why the 2 mins are an issue any longer?

to wait needlessly 2 minutes to see that your job failed for a stupid user error

Please note that jobs that are active (queued, running) are refreshed separately every ten seconds! So if you queue a job and it fails after 5 seconds, you'll be notified 10 secs after the queueing request. I think that's reasonably fast.

@soxofaan
Copy link
Member Author

But with the proposal above you could simply click refresh,

I understood that that button only would appear when there was an error/partial result (I mean error in aggregating multiple backends, not a failing job).

Please note that jobs that are active (queued, running) are refreshed separately every ten seconds! So if you queue a job and it fails after 5 seconds, you'll be notified 10 secs after the queueing request. I think that's reasonably fast.

Ok I wasn't aware of these details, nevermind then

@m-mohr m-mohr modified the milestones: v0.11, v0.12 Apr 7, 2022
@m-mohr m-mohr modified the milestones: v0.12, future Jul 19, 2022
@m-mohr m-mohr removed their assignment Jul 19, 2022
@m-mohr
Copy link
Member

m-mohr commented Nov 2, 2022

The refresh button is back :-)

@m-mohr m-mohr closed this as completed Nov 2, 2022
@m-mohr m-mohr removed this from the future milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants