From bf0fe7439610b894de554327e6ec40b2b9bb4af2 Mon Sep 17 00:00:00 2001 From: Nan Date: Thu, 22 Feb 2024 10:17:26 -0800 Subject: [PATCH] rename setSharedInstance to workaround false flagging * App Store Connect is flagging our method `setSharedInstance` in a false negative manner * Error states: Asset validation failed... The app references non-public selectors in Payload/Runner.app/Frameworks/OneSignalFramework.framework/OneSignalFramework: setSharedInstance --- .../OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.h | 2 +- .../OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.m | 2 +- iOS_SDK/OneSignalSDK/Source/OneSignal.m | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.h b/iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.h index 3c842a306..46abd68b6 100644 --- a/iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.h +++ b/iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.h @@ -35,6 +35,6 @@ typedef void (^OSDialogActionCompletion)(int tappedActionIndex); @end @interface OSDialogInstanceManager : NSObject -+ (void)setSharedInstance:(NSObject *_Nonnull)instance; ++ (void)setSharedOSDialogInstance:(NSObject *_Nonnull)instance; + (NSObject *_Nullable)sharedInstance; @end diff --git a/iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.m b/iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.m index b24b09d6f..e2c2d5029 100644 --- a/iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.m +++ b/iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSDialogInstanceManager.m @@ -30,7 +30,7 @@ of this software and associated documentation files (the "Software"), to deal @implementation OSDialogInstanceManager static NSObject *_sharedInstance; -+ (void)setSharedInstance:(NSObject *_Nonnull)instance { ++ (void)setSharedOSDialogInstance:(NSObject *_Nonnull)instance { _sharedInstance = instance; } diff --git a/iOS_SDK/OneSignalSDK/Source/OneSignal.m b/iOS_SDK/OneSignalSDK/Source/OneSignal.m index c1d793bd7..4f151908d 100755 --- a/iOS_SDK/OneSignalSDK/Source/OneSignal.m +++ b/iOS_SDK/OneSignalSDK/Source/OneSignal.m @@ -789,7 +789,7 @@ + (void)load { // sessionLaunchTime = [NSDate date]; // TODO: sessionLaunchTime used to always be set in load - [OSDialogInstanceManager setSharedInstance:[OneSignalDialogController sharedInstance]]; + [OSDialogInstanceManager setSharedOSDialogInstance:[OneSignalDialogController sharedInstance]]; } /*