Review of mappings to P01 for oxygen

[matdon17]

In July 2020 I made some suggestions to update the Argo parameters list Excel file named:

• argo-parameters-list-core-and-b_CS_20180129.xlsx

Specifically:

DPHASE_DOXY - currently OXYCPHAB, but this is actually C1PHASE_DOXY - I recommend OXYCPHAC
TPHASE_DOXY - currently OXYCPHAC, but this is actually DPHASE_DOXY - I recommend OXYCPHTC
C1PHASE_DOXY - currently OCYCPHAD, but doesn't exist - I recommend OXYCPHAB
C2PHASE_DOXY - currently OXYCPHAE, but doesn't exist - I recommend OXYCPHAR

At the time of writing, the Excel file was last updated in February 2021, but some problems remain:

• the entry in sdn_parameter_urn for C1PHASE_DOXY remains incorrect as "OCYCPHAB" rather than "OXYCPHAB"
• this is causing the test in sdn_parameter_uri for C1PHASE_DOXY to also be wrong
• the hyperlink in sdn_parameter_uri is wrong for all of the variables mentioned above - the cell formula is correct, but the cell itself seems to have the old hyperlink in use instead if you mouse-over of click on it

Looking at P01 mappings that have been transferred into R03 and we see:

• DPHASE_DOXY - mapped to OXYCPHAC as expected
• TPHASE_DOXY - mapped to OXYCPHTC as expected
• C1PHASE_DOXY - not mapped, probably because of the issue outlined above
• C2PHASE_DOXY - mapped to OXYCPHAR, as expected

So I recommend that:

• the spreadsheet be further updated to correct C1PHASE_DOXY mapping to P01 from "OCYCPHAB" to "OXYCPHAB"
• correct the links in the spreadsheet for all these parameters
• we add the mapping to OXYCPHAB for http://vocab.nerc.ac.uk/collection/R03/current/C1PHASE_DOXY/

This issue has been flagged due to a carry-over issue from Argo to EGO gliders formats and the OG1 vocabulary, see:
http://vocab.nerc.ac.uk/search_nvs/OG1/?searchstr=oxy&options=identifier,preflabel,altlabel,status_accepted&rbaddfilter=inc&searchstr2=

@vpaba @bodcmahe @catsch @tcarval

[catsch]

Hi Matt, Sorry If I miss the suggested modifications, I will do a release next week of the excel sheet. Catherine

…

-- Catherine Schmechtig 0681827411 LEFE-CYBER Database http://www.obs-vlfr.fr/proof BGC Argo http://biogeochemical-argo.org/ https://github.com/catsch OSU Ecce Terra Sorbonne Université - CNRS - UMS 3455 4, Place Jussieu 75 252 Paris Cedex 05 Tour 45 - couloir 45-55 2eme etage - 207 De: "Matt Donnelly" ***@***.***> À: "nvs-vocabs/R03" ***@***.***> Cc: "Catherine Schmechtig" ***@***.***>, "Mention" ***@***.***> Envoyé: Mardi 22 Juin 2021 13:36:34 Objet: [nvs-vocabs/R03] Review of mappings to P01 for oxygen (#4) In July 2020 I made some suggestions to update the Argo parameters list Excel file named: * argo-parameters-list-core-and-b_CS_20180129.xlsx Specifically: DPHASE_DOXY - currently OXYCPHAB, but this is actually C1PHASE_DOXY - I recommend OXYCPHAC TPHASE_DOXY - currently OXYCPHAC, but this is actually DPHASE_DOXY - I recommend OXYCPHTC C1PHASE_DOXY - currently OCYCPHAD, but doesn't exist - I recommend OXYCPHAB C2PHASE_DOXY - currently OXYCPHAE, but doesn't exist - I recommend OXYCPHAR At the time of writing, the Excel file was last updated in February 2021, but some problems remain: * the entry in sdn_parameter_urn for C1PHASE_DOXY remains incorrect as "OCYCPHAB" rather than "OXYCPHAB" * this is causing the test in sdn_parameter_uri for C1PHASE_DOXY to also be wrong * the hyperlink in sdn_parameter_uri is wrong for all of the variables mentioned above - the cell formula is correct, but the cell itself seems to have the old hyperlink in use instead if you mouse-over of click on it Looking at P01 mappings that have been transferred into R03 and we see: * DPHASE_DOXY - mapped to OXYCPHAC as expected * TPHASE_DOXY - mapped to OXYCPHTC as expected * C1PHASE_DOXY - not mapped, probably because of the issue outlined above * C2PHASE_DOXY - mapped to OXYCPHAR, as expected So I recommend that: * the spreadsheet be further updated to correct C1PHASE_DOXY mapping to P01 from "OCYCPHAB" to "OXYCPHAB" * correct the links in the spreadsheet for all these parameters * we add the mapping to OXYCPHAB for [ http://vocab.nerc.ac.uk/collection/R03/current/C1PHASE_DOXY/ | http://vocab.nerc.ac.uk/collection/R03/current/C1PHASE_DOXY/ ] This issue has been flagged due to a carry-over issue from Argo to EGO gliders formats and the OG1 vocabulary, see: [ http://vocab.nerc.ac.uk/search_nvs/OG1/?searchstr=oxy&options=identifier,preflabel,altlabel,status_accepted&rbaddfilter=inc&searchstr2= | http://vocab.nerc.ac.uk/search_nvs/OG1/?searchstr=oxy&options=identifier,preflabel,altlabel,status_accepted&rbaddfilter=inc&searchstr2= ] [ https://github.com/vpaba | @vpaba ] [ https://github.com/bodcmahe | @bodcmahe ] [ https://github.com/catsch | @catsch ] [ https://github.com/tcarval | @tcarval ] — You are receiving this because you were mentioned. Reply to this email directly, [ #96 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AEJ4NPWDLTXH65G3RN4CIO3TUBYUFANCNFSM47DPQBNA | unsubscribe ] .

[catsch]

@matt Could you check that I made the required changes regarding to parameters relative to DOXY? Thank you Catherine -- Catherine Schmechtig 0681827411 LEFE-CYBER Database http://www.obs-vlfr.fr/proof BGC Argo http://biogeochemical-argo.org/ https://github.com/catsch OSU Ecce Terra Sorbonne Université - CNRS - UMS 3455 4, Place Jussieu 75 252 Paris Cedex 05 Tour 45 - couloir 45-55 2eme etage - 207 De: "Matt Donnelly" ***@***.***> À: "nvs-vocabs" ***@***.***> Cc: "Catherine Schmechtig" ***@***.***>, "Mention" ***@***.***> Envoyé: Mardi 22 Juin 2021 13:36:34 Objet: [nvs-vocabs/R03] Review of mappings to P01 for oxygen (#4) In July 2020 I made some suggestions to update the Argo parameters list Excel file named: * argo-parameters-list-core-and-b_CS_20180129.xlsx Specifically: DPHASE_DOXY - currently OXYCPHAB, but this is actually C1PHASE_DOXY - I recommend OXYCPHAC TPHASE_DOXY - currently OXYCPHAC, but this is actually DPHASE_DOXY - I recommend OXYCPHTC C1PHASE_DOXY - currently OCYCPHAD, but doesn't exist - I recommend OXYCPHAB C2PHASE_DOXY - currently OXYCPHAE, but doesn't exist - I recommend OXYCPHAR At the time of writing, the Excel file was last updated in February 2021, but some problems remain: * the entry in sdn_parameter_urn for C1PHASE_DOXY remains incorrect as "OCYCPHAB" rather than "OXYCPHAB" * this is causing the test in sdn_parameter_uri for C1PHASE_DOXY to also be wrong * the hyperlink in sdn_parameter_uri is wrong for all of the variables mentioned above - the cell formula is correct, but the cell itself seems to have the old hyperlink in use instead if you mouse-over of click on it Looking at P01 mappings that have been transferred into R03 and we see: * DPHASE_DOXY - mapped to OXYCPHAC as expected * TPHASE_DOXY - mapped to OXYCPHTC as expected * C1PHASE_DOXY - not mapped, probably because of the issue outlined above * C2PHASE_DOXY - mapped to OXYCPHAR, as expected So I recommend that: * the spreadsheet be further updated to correct C1PHASE_DOXY mapping to P01 from "OCYCPHAB" to "OXYCPHAB" * correct the links in the spreadsheet for all these parameters * we add the mapping to OXYCPHAB for [ http://vocab.nerc.ac.uk/collection/R03/current/C1PHASE_DOXY/ | http://vocab.nerc.ac.uk/collection/R03/current/C1PHASE_DOXY/ ] This issue has been flagged due to a carry-over issue from Argo to EGO gliders formats and the OG1 vocabulary, see: [ http://vocab.nerc.ac.uk/search_nvs/OG1/?searchstr=oxy&options=identifier,preflabel,altlabel,status_accepted&rbaddfilter=inc&searchstr2= | http://vocab.nerc.ac.uk/search_nvs/OG1/?searchstr=oxy&options=identifier,preflabel,altlabel,status_accepted&rbaddfilter=inc&searchstr2= ] [ https://github.com/vpaba | @vpaba ] [ https://github.com/bodcmahe | @bodcmahe ] [ https://github.com/catsch | @catsch ] [ https://github.com/tcarval | @tcarval ] — You are receiving this because you were mentioned. Reply to this email directly, [ #96 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AEJ4NPWDLTXH65G3RN4CIO3TUBYUFANCNFSM47DPQBNA | unsubscribe ] .

[catsch]

Hi all, done on july 2020 but the issue was not close, done now