Propagate Errors from Router Task for Improved Reliability

[ametel01]

fossil-headers-db/src/indexer/lib.rs

Line 58 in 522f4a5

if let Err(e) = router::initialize_router(db_clone, router_terminator).await {

Description:
The router task in the indexing service currently logs any error returned from router::initialize_router but then always returns Ok(()). This behavior can hide critical startup issues that may occur when initializing the router. Instead of silently proceeding, the task should propagate the error or handle it explicitly to ensure that any critical failures are properly addressed.

Steps to Reproduce:

1. Simulate an error during router initialization by causing router::initialize_router to fail.
2. Observe that the error is logged but the task still returns Ok(()), masking the failure.

Proposed Fix:
Modify the router task to propagate the error rather than returning Ok(()) after logging. For example:

let router_handle = tokio::spawn(async move {
    router::initialize_router(db_clone, router_terminator).await
});

Or, if additional cleanup or logging is needed, return the error accordingly.

Impact:
Propagating errors from the router task will help catch critical startup issues early and allow for a more robust error handling strategy in the indexing service.