-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network sideload fails but npm run start sideload works #5215
Comments
Mark it as #9642233 into our backlog |
Hi @duane-j-wagner, I consulted our expert and got such explanation. |
Perhaps I didn't explain the problem well enough.
|
@duane-j-wagner, based on you shared manifest file, your addin will not show. Everything is hidden, I don't get your point on "until the initialization code makes it visible". Do you mean you something would happen (or run) to make tab from invisible to visible? |
Yes. I followed the advice on MS learn to create a contextual tab |
@duane-j-wagner, would you please share your 'onReady' code here? I can transfer it to the expert. |
The code can be inspected by installing the add-in in Excel with the manifest linked in the original post and using the web view dev tools.
main() is in main.ts and is run by the angular framework. When using dev tools, filter the code on 'app/' to see the typescript and filter out the generated javascript and node module code.
|
Hi @duane-j-wagner, would you please confirm that which one is correct in your case:
|
|
If I try to debug the Office365 version of Excel, When I upload the manifest, I see the text from the manifest that my add-in installed successfully, but the tab was not added to the ribbon. In the Network tab of the Edge dev tools, I do not see any office.js loaded and the console has no useful errors. |
And onReady works as expected on mac? Does web on mac work unexpected here? |
On mac using Google Chrome, I have the same result as on Windows with Edge. |
Here are some similar issues that might help you. Please check if they can solve your problem. Possible solution (Extracted from existing issue, might be incorrect; please verify carefully) Upon further inspection, we found that svg icons are not supported. When we replaced all the svg icons with png, the issue got resolved. You may close this. Reference: |
The bot is hallucinating. My manifest has only png icons. |
Provide required information needed to triage your issue
Your Environment
Expected behavior
The add in should be initialized on install, causing the custom contextual tab and the task pane to show.
Current behavior
The add-in does nothing on a network share install on a PC, nor when uploaded on Web. The custom contextual tab remains hidden and the task pane does not show.
if the OverriddenByRibbonApi tag in the manifest is set to false, the add-in installs and initializes as expected.
The whole point of that tag is to hide the control that should only be shown when overriding the control is not supported, so setting to false leads to a poor user experience.
Mac side-loading works as expected. npm run start side-loading also works on PC.
Steps to reproduce
Link to live example(s)
Provide additional details
Context
We need to side load in order for QA to test on PC and Web. Side-loading works on Mac.
Useful logs
The onReady() method never gets called and there are no errors. Excel shows a status at the bottom of window that the add-in was installed successfully.
Thank you for taking the time to report an issue. Our triage team will respond to you in less than 72 hours. Normally, response time is <10 hours Monday through Friday. We do not triage on weekends.
The text was updated successfully, but these errors were encountered: