Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release after #406 #412

Closed
domire8 opened this issue Mar 6, 2024 · 12 comments
Closed

New release after #406 #412

domire8 opened this issue Mar 6, 2024 · 12 comments

Comments

@domire8
Copy link

domire8 commented Mar 6, 2024

Hi there!

Any chance there could be a new patch version after #406? This is a great fix and would be great to have a tagged version for this.

Thank you!

@wxmerkt
Copy link
Member

wxmerkt commented Mar 12, 2024

Hi @ahornung
Could you please prepare a new release?

Can we please get the following PRs merged first (both minor and CI/ROS-release related):

  1. Declare missing octovis dependency on opengl #408
  2. [CI] Remove ccache #413

The diff between the last release (1.9.8) and master is the following: v1.9.8...devel - we may need to bump the minor version rather than a patch version?

What do you think?

@clalancette
Copy link
Contributor

We also need this to be released in order to make octomap build on Noble; see https://build.ros2.org/job/Rbin_uN64__octomap__ubuntu_noble_amd64__binary/8/console . In particular, we need #373 released so it will build cleanly.

It would also be nice to get #415 in, though it isn't strictly required to make it build (it will just have warnings).

@ahornung
Copy link
Member

ahornung commented Mar 14, 2024 via email

@ahornung
Copy link
Member

@wxmerkt @clalancette thanks, looking good so far with the PRs! Updated release coming soon.

@clalancette
Copy link
Contributor

@wxmerkt @clalancette thanks, looking good so far with the PRs! Updated release coming soon.

Thank you, much appreciated!

@ahornung
Copy link
Member

Done, v1.10.0 released!

@clalancette
Copy link
Contributor

Done, v1.10.0 released!

Fantastic, thank you so much. Are you planning on doing a bloom-release of this for ROS 2, or would you prefer that I do it?

@ahornung
Copy link
Member

I'm not really tracking or maintaining the ROS releases anymore, so if either @wxmerkt or you do it that's fine by me.

@clalancette
Copy link
Contributor

I'm not really tracking or maintaining the ROS releases anymore, so if either @wxmerkt or you do it that's fine by me.

All right, I'll go ahead and do it.

@clalancette
Copy link
Contributor

And here is the release into Rolling: ros/rosdistro#40273

@wxmerkt
Copy link
Member

wxmerkt commented Mar 20, 2024

Thank you for the time to review, merge, and release @ahornung - much appreciated.

@clalancette Thanks for making the release. I had some issues with bloom-release creating the release but not opening the PR

@domire8
Copy link
Author

domire8 commented Mar 25, 2024

Thank you all, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants