[16.0][FIX] l10n_pt_vat: Fiscal zone invisible if country is not Portugal #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dreispt, |
dreispt
approved these changes
Feb 26, 2025
|
Tests are failing, could be related to the issue Pedro Baeza reported on the Contributors ML. |
|
@EmilioPascual #88 might also be interesting for you |
loida-vm
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Functional review done.
Since the Portuguese company is registered with its accounting, the fiscal zone field is added to indicate whether it is Portugal Continental, Madeira, or Azores.
I have registered other companies, France and Spain, along with their accounting, and in the taxes, this field no longer appears, as it is not necessary.
LGTM!! 👍🏼
Thank you @EmilioPascual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@loida-vm @dreispt please review. Thanks!
Company is from Portugal
Company is not from Portugal
@moduon MT-9204