[18.0][MIG] hr_holidays_public: Migration to 18.0 #159

xaviedoanhduy · 2024-12-26T11:54:09Z

note

depend applied on new module: [18.0][ADD] calendar_public_holiday calendar#142
most of the tests that were removed during this migration have been added to the calendar_public_holiday module.

victoralmau · 2025-02-13T15:33:10Z

Now that calendar_public_holiday is already merged, can you delete the commit [DON'T MERGE] Add test-requirements.txt and I'll check it?

Add correct calculation of holidays in hr_public_holidays, instead of hr_holidays_compute_days. Remove dependancy of contracts. Add unlink at onchnage of public holiday lines. Update code. Fix flake. Update code, add calculation in hours, update views. Update flake. Update calendar creation with no attendances, otherwise default values were set. Remove config of show days/hours. Update flake. Update readme. Rename module. Updated holiday reports. Update klake and pylint. Update flaket. Update hr_holidays_views.xml Add readonly to show_full_days. Update code according with comments. Increase coverage. update flake8.

Hours part will be in module hr_holidays_hour.

Reduce to the minimum the footprint of this module, adding only public holidays as leaves in a transparent way by other modules.

This has been totally reworked for decoupling parts, not depending now on hr_holidays_public, and making transparent its use for compatibility with other modules.

Currently translated at 52.5% (21 of 40 strings) Translation: hr-11.0/hr-11.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_public/de/

Currently translated at 55.0% (22 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/

Currently translated at 95.0% (38 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/fr/

Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/

Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/de/

Currently translated at 100.0% (40 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/

…idays are defined for each year

Currently translated at 45.0% (18 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/pt_BR/

Adapt to odoo/odoo@cc0f6e2

Since that PR, `_leave_intervals` is no longer called on days computations, so we intercept the batch method, but leaving the previous one for retro-compatibility.

This change hooks into the core public holidays method that returns the employee's available holidays for a period of time and displays them in the Time Off dashboard calendar. Both types of public holidays are compatible and will show up in order. TT52276

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/

Currently translated at 100.0% (42 of 42 strings) Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/it/

victoralmau

Code and functional review OK.

This change is pending OCA/calendar#142 (comment)

hr_holidays_public/readme/USAGE.md

victoralmau · 2025-02-14T07:47:42Z

Comment OCA/calendar#142 (comment) is still pending.

xaviedoanhduy · 2025-02-21T03:18:52Z

Comment OCA/calendar#142 (comment) is still pending.

hi, I added a commit in response to that comment

victoralmau · 2025-02-21T07:38:01Z

Comment OCA/calendar#142 (comment) is still pending.

hi, I added a commit in response to that comment

Can you add it in a .csv file to make it more readable? (similar to https://github.com/OCA/calendar/blob/18.0/calendar_public_holiday/security/ir.model.access.csv) I think this change does not need to be in an extra commit, it can be in the migration commit.

xaviedoanhduy · 2025-02-25T03:00:36Z

Can you add it in a .csv file to make it more readable? (similar to https://github.com/OCA/calendar/blob/18.0/calendar_public_holiday/security/ir.model.access.csv) I think this change does not need to be in an extra commit, it can be in the migration commit.

ok, updated

victoralmau

Code and functional review OK.

Ping @pedrobaeza

OCA-git-bot · 2025-02-26T11:54:41Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2025-02-26T13:12:17Z

/ocabot migration hr_holidays_public

pedrobaeza

I'm missing a menu entry for managing public holidays for HR managers.

hr_holidays_public/models/hr_leave.py

xaviedoanhduy · 2025-02-27T08:34:42Z

I'm missing a menu entry for managing public holidays for HR managers.

hi, are you confused between Time off and Employees? because i brought it back to the original module where the time off manager has the right

pedrobaeza · 2025-02-27T08:56:03Z

I'm talking about a menu entry. I see the security access rules, but not UI counterpart for managing the public holidays from inside the Time Off menus.

xaviedoanhduy · 2025-02-27T09:29:33Z

added menu in manage public holidays inside the Time Off menus.

xaviedoanhduy mentioned this pull request Dec 26, 2024

[18.0][MIG] hr_holidays_public: Migration to 18.0 #147

Closed

Fekete Mihai and others added 28 commits February 13, 2025 22:34

[FIX] hr_holidays_public: Review comments

6dafd5e

[FIX+IMP] hr_holidays_public: Strip hours part + complete migration

2f7a8e6

Hours part will be in module hr_holidays_hour.

[IMP] hr_holidays_public: Leave only public holidays computation

a7cc2fb

Reduce to the minimum the footprint of this module, adding only public holidays as leaves in a transparent way by other modules.

[MIG] hr_holidays_compute_days: Adapt to 11.0 + minimize

99d5006

This has been totally reworked for decoupling parts, not depending now on hr_holidays_public, and making transparent its use for compatibility with other modules.

Translated using Weblate (German)

55ed3fc

Currently translated at 52.5% (21 of 40 strings) Translation: hr-11.0/hr-11.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_public/de/

[MIG] hr_holidays_public: Migration to 12.0

8a04901

Translated using Weblate (Spanish)

6f9144f

Currently translated at 55.0% (22 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/

Translated using Weblate (French)

f0fb9ae

Currently translated at 95.0% (38 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/fr/

Translated using Weblate (Spanish)

c6d7e0b

Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/

Translated using Weblate (German)

4ea7409

Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/de/

Translated using Weblate (Spanish)

f9e3c6c

Currently translated at 100.0% (40 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/

FIX: fix leave number days when requested across years and public hol…

d1144eb

…idays are defined for each year

hr_holidays_public 12.0.1.0.1

533daf4

[12.0][FIX] hr_holiday_public: Fix method return for concatenation

ce5f69a

[FIX] hr_holiday_public: Delete holidays public

6e3e294

Translated using Weblate (Portuguese (Brazil))

62e52c6

Currently translated at 45.0% (18 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/pt_BR/

[IMP] hr_holidays_public: black, isort

d8ea7db

[MIG] hr_holidays_public: Migration to 13.0

f40e480

[FIX] hr_public_holidays: add tz argument in _work_intervals

007906e

Adapt to odoo/odoo@cc0f6e2

hr_holidays_public 13.0.1.0.1

4012d24

[FIX] hr_holidays_public: Adapt to odoo/odoo#51542

80f0e64

Since that PR, `_leave_intervals` is no longer called on days computations, so we intercept the batch method, but leaving the previous one for retro-compatibility.

[UPD] Brainbean Apps => CorporateHub

cf23d5c

[IMP] hr_holidays_public: Create global calendar.event

bfcc5ed

[IMP] Update categ_ids only if available

1690d34

hr_holidays_public 13.0.3.0.0

0854db2

[IMP] hr_holidays_public: black, isort, prettier

16f8848

Add fix OCA#20 to 14.0

4c69916

OCA-git-bot and others added 6 commits February 13, 2025 22:34

[BOT] post-merge updates

18f69ef

[UPD] Update hr_holidays_public.pot

f1b1a8b

[BOT] post-merge updates

1e15c55

Update translation files

c0042fe

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/

Translated using Weblate (Italian)

0c1d77d

Currently translated at 100.0% (42 of 42 strings) Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/it/

xaviedoanhduy force-pushed the 18.0-imp-hr-holidays-public branch from 3cdd58e to 374acb3 Compare February 13, 2025 15:35

victoralmau suggested changes Feb 13, 2025

View reviewed changes

hr_holidays_public/readme/USAGE.md Outdated Show resolved Hide resolved

xaviedoanhduy force-pushed the 18.0-imp-hr-holidays-public branch from 374acb3 to 0b3df3b Compare February 14, 2025 02:51

xaviedoanhduy force-pushed the 18.0-imp-hr-holidays-public branch from 9e4c7f4 to a6b4bac Compare February 25, 2025 02:59

victoralmau approved these changes Feb 25, 2025

View reviewed changes

ArnauCForgeFlow approved these changes Feb 26, 2025

View reviewed changes

OCA-git-bot added the approved label Feb 26, 2025

ArnauCForgeFlow mentioned this pull request Feb 26, 2025

[18.0][MIG] hr_holidays_public_work_location: Migration to 18.0 #166

Open

OCA-git-bot added the ready to merge label Feb 26, 2025

OCA-git-bot added this to the 18.0 milestone Feb 26, 2025

OCA-git-bot mentioned this pull request Feb 26, 2025

Migration to version 18.0 #145

Open

4 tasks

pedrobaeza reviewed Feb 26, 2025

View reviewed changes

hr_holidays_public/models/hr_leave.py Outdated Show resolved Hide resolved

xaviedoanhduy force-pushed the 18.0-imp-hr-holidays-public branch from a6b4bac to d02a400 Compare February 27, 2025 08:32

[MIG] hr_holidays_public: Migration to 18.0

fb38c0f

xaviedoanhduy force-pushed the 18.0-imp-hr-holidays-public branch from d02a400 to fb38c0f Compare February 27, 2025 09:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] hr_holidays_public: Migration to 18.0 #159

[18.0][MIG] hr_holidays_public: Migration to 18.0 #159

xaviedoanhduy commented Dec 26, 2024

victoralmau commented Feb 13, 2025

victoralmau left a comment

victoralmau commented Feb 14, 2025

xaviedoanhduy commented Feb 21, 2025

victoralmau commented Feb 21, 2025

xaviedoanhduy commented Feb 25, 2025

victoralmau left a comment

OCA-git-bot commented Feb 26, 2025

pedrobaeza commented Feb 26, 2025

pedrobaeza left a comment

xaviedoanhduy commented Feb 27, 2025

pedrobaeza commented Feb 27, 2025

xaviedoanhduy commented Feb 27, 2025

[18.0][MIG] hr_holidays_public: Migration to 18.0 #159

Are you sure you want to change the base?

[18.0][MIG] hr_holidays_public: Migration to 18.0 #159

Conversation

xaviedoanhduy commented Dec 26, 2024

note

victoralmau commented Feb 13, 2025

victoralmau left a comment

Choose a reason for hiding this comment

victoralmau commented Feb 14, 2025

xaviedoanhduy commented Feb 21, 2025

victoralmau commented Feb 21, 2025

xaviedoanhduy commented Feb 25, 2025

victoralmau left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Feb 26, 2025

pedrobaeza commented Feb 26, 2025

pedrobaeza left a comment

Choose a reason for hiding this comment

xaviedoanhduy commented Feb 27, 2025

pedrobaeza commented Feb 27, 2025

xaviedoanhduy commented Feb 27, 2025