Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect gpufail=1 after gpu probe updates #229

Closed
lars-t-hansen opened this issue Jan 13, 2025 · 0 comments
Closed

Incorrect gpufail=1 after gpu probe updates #229

lars-t-hansen opened this issue Jan 13, 2025 · 0 comments
Assignees
Labels
bug Something isn't working REGRESSION

Comments

@lars-t-hansen
Copy link
Collaborator

Changeset 9d623ce introduced a bug: nodes with no GPU will now signal gpufail=1. This is because the gpu probe only distinguishes between found and not found, and the PS code takes the latter to be an error, but this is wrong and was caused by this patch, which previously would signal gpufail=1 only if the probe returned an Err, it being a Result previously with an empty-array return for no GPUs.

This is a problem on main only, 0.12 is unaffected.

The fact that this bug made it through is a result of not having good test cases for the gpu probes, #217. We need to be able to run a test suite on hardware that has no GPUs, NVIDIA gpus, AMD gpus and then be able to state expectations for the tests on the various nodes. It's a little involved and won't work as part of CI, but it's definitely something we want.

@lars-t-hansen lars-t-hansen added the bug Something isn't working label Jan 13, 2025
@lars-t-hansen lars-t-hansen self-assigned this Jan 13, 2025
@bast bast closed this as completed in cccacde Jan 13, 2025
bast added a commit that referenced this issue Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working REGRESSION
Projects
None yet
Development

No branches or pull requests

1 participant