Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace @slimio/async-cli-spinner with @topcli/spinner #166

Closed
fraxken opened this issue Jan 3, 2025 · 5 comments
Closed

replace @slimio/async-cli-spinner with @topcli/spinner #166

fraxken opened this issue Jan 3, 2025 · 5 comments
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers

Comments

@fraxken
Copy link
Member

fraxken commented Jan 3, 2025

@slimio/async-cli-spinner is a legacy package that we refactored/migrated to TopCLI. So we should use the newest maintained package @topcli/spinner.

@fraxken fraxken added enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Jan 3, 2025
@Brijeshthummar02
Copy link

@fraxken i can fix it, can you just show me the path to the file where it should be corrected.

@fraxken
Copy link
Member Author

fraxken commented Jan 3, 2025

@Brijeshthummar02 Just use CTRL+Shift+F and search for the package name

@Brijeshthummar02
Copy link

Brijeshthummar02 commented Jan 3, 2025

@fraxken can you provide exact version no, for @topcli/spinner as i am also changing package.json file, scanner.ts file uppdated now only package.json left do i need to update it also?

@fraxken
Copy link
Member Author

fraxken commented Jan 3, 2025

??? Remove the old package and install the new one using npm

@PierreDemailly
Copy link
Member

Fixed by #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants