From 3ac49bcf9448279897b6530f6c68db140b57aac6 Mon Sep 17 00:00:00 2001 From: Philip Taron Date: Tue, 18 Jun 2024 10:39:32 -0700 Subject: [PATCH] nixos/bluemap: fix defaults issue with `services.bluemap.host` The default for this value depends on `config.networking.domain`, which is typed as `types.nullOr types.str` in nixos/modules/tasks/network-interfaces.nix As a result, the default for `services.bluemap.host` either has to be `types.nullOr types.str`, or we need to drop the default. Based on PR feedback, this commit drops the default and requires configuration through the `services.bluemap.host` option. While this is a breaking change, since the module is a month old, there should be very few users so far. --- nixos/modules/services/web-servers/bluemap.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/nixos/modules/services/web-servers/bluemap.nix b/nixos/modules/services/web-servers/bluemap.nix index 28eaad3db313e..731468fd9a0ec 100644 --- a/nixos/modules/services/web-servers/bluemap.nix +++ b/nixos/modules/services/web-servers/bluemap.nix @@ -71,9 +71,7 @@ in { host = mkOption { type = lib.types.str; - default = "bluemap.${config.networking.domain}"; - defaultText = lib.literalExpression "bluemap.\${config.networking.domain}"; - description = "Domain to configure nginx for"; + description = "Domain on which nginx will serve the bluemap webapp"; }; onCalendar = mkOption {