Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: lazyjj #370890

Open
ryane opened this issue Jan 4, 2025 · 2 comments
Open

Build failure: lazyjj #370890

ryane opened this issue Jan 4, 2025 · 2 comments
Labels
0.kind: build failure A package fails to build

Comments

@ryane
Copy link
Contributor

ryane commented Jan 4, 2025

Steps To Reproduce

Steps to reproduce the behavior:

  1. build lazyjj (nix run nixpkgs#lazyjj)

Build log

Build Log
error: builder for '/nix/store/5s58rwnlggjiy89ynba5vjkmc57ldr8h-lazyjj-0.4.2.drv' failed with exit code 101;
       last 25 log lines:
       > Snapshot: get_commit_show
       > Source: src/commander/log.rs:373
       > ────────────────────────────────────────────────────────────────────────────────
       > Expression: show
       > ────────────────────────────────────────────────────────────────────────────────
       > -old snapshot
       > +new results
       > ────────────┬───────────────────────────────────────────────────────────────────
       >     0       │-"Commit ID: [COMMIT_ID]\nChange ID: [Change ID]\nAuthor: lazyjj <[email protected]> (([DATE_TIME]))\nCommitter: lazyjj <lazyjj@example
.com> (([DATE_TIME]))\n\n    (no description set)\n\nAdded regular file README:\n        1: AAA"
       >           0 │+"Commit ID: [COMMIT_ID]\nChange ID: [Change ID]\nAuthor   : lazyjj <[email protected]> (([DATE_TIME]))\nCommitter: lazyjj <lazyjj@exam
ple.com> (([DATE_TIME]))\n\n    (no description set)\n\nAdded regular file README:\n        1: AAA"
       > ────────────┴───────────────────────────────────────────────────────────────────
       > To update snapshots run `cargo insta review`
       > Stopped on the first failure. Run `cargo insta test` to run all snapshots.
       > thread 'commander::log::tests::get_commit_show' panicked at /build/lazyjj-0.4.2-vendor.tar.gz/insta/src/runtime.rs:548:9:
       > snapshot assertion for 'get_commit_show' failed in line 373
       >
       >
       > failures:
       >     commander::bookmarks::tests::get_bookmark_show
       >     commander::files::tests::get_file_diff
       >     commander::log::tests::get_commit_show
       >
       > test result: FAILED. 20 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.16s
       >
       > error: test failed, to rerun pass `--bin lazyjj`
       For full logs, run 'nix log /nix/store/5s58rwnlggjiy89ynba5vjkmc57ldr8h-lazyjj-0.4.2.drv'.

Additional context

Metadata

❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.69, NixOS, 25.05 (Warbler), 25.05.20250102.6df2492`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.11`
 - nixpkgs: `/nix/store/apfqvr9kddcl6fscjvb92p4xdrqzcwk0-source`

Notify maintainers

@colemickens


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@ryane ryane added the 0.kind: build failure A package fails to build label Jan 4, 2025
@poopsicles
Copy link
Contributor

upstream tests are outdated, the "Author:" and "Committer:" bits are aligned with jj v0.25.0: jj-vcs/jj@0794f87#diff-e069c2f020ff56b3a4a5c5844282b24370c9ff597f086c93398830e87b84c385

@uncenter
Copy link
Member

uncenter commented Jan 4, 2025

Was mentioned here fwiw: #370160 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build
Projects
None yet
Development

No branches or pull requests

3 participants