From 3153719e453daa9a2caac6f1375cda6bcd6ec0ad Mon Sep 17 00:00:00 2001 From: Fritz Otlinghaus Date: Mon, 6 Jan 2025 18:01:08 +0100 Subject: [PATCH] add tracking for api errors --- nixpkgs_merge_bot/commands/merge.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nixpkgs_merge_bot/commands/merge.py b/nixpkgs_merge_bot/commands/merge.py index e068d8b..bef74a8 100644 --- a/nixpkgs_merge_bot/commands/merge.py +++ b/nixpkgs_merge_bot/commands/merge.py @@ -108,7 +108,7 @@ def merge_command(issue_comment: IssueComment, settings: Settings) -> HttpRespon if check: one_merge_strategy_passed = True decline_reasons = [] - continue + break for reason in decline_reasons: log.info(f"{issue_comment.issue_number}: {reason}") @@ -167,6 +167,8 @@ def merge_command(issue_comment: IssueComment, settings: Settings) -> HttpRespon return issue_response("merged") except GithubClientError as e: log.exception(f"{issue_comment.issue_number}: merge failed") + msg = "GitHub API error (#371492):" # Link Issue to track errors + decline_reasons.append(msg) decline_reasons.extend( [ f"@{issue_comment.commenter_login} merge failed:",