Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitty images on non Kitty terminals #107

Open
rhodes-b opened this issue Jan 19, 2025 · 0 comments
Open

Kitty images on non Kitty terminals #107

rhodes-b opened this issue Jan 19, 2025 · 0 comments

Comments

@rhodes-b
Copy link

Quite a few terminals support kitty image protocol today

Konsole, Wezterm, Ghostty to name a few why in the force kitty output do you still check if the terminal is actually kitty that isnt forcing it at all

ctpv/sh/helpers.sh

Lines 29 to 36 in 4efa0f9

is_kitty() {
[ -n "$KITTY_PID" ] && return 0
case "$TERM" in
*-kitty) return 0 ;;
*) return 1 ;;
esac
}

[ -n "$forcekitty" ] && is_kitty && { image_method="$image_method_kitty"; return 0; }

btw you can query if a terminal supports kitty image protocol so you can stop doing name matching
https://sw.kovidgoyal.net/kitty/graphics-protocol/#querying-support-and-available-transmission-mediums

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant