-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpd-fileupload process.server.options (line 15) breaks when using grunt-dpdjs #72
Comments
we have some changes that we haven't released yet that could solve your problem. can you try and tell me if it solves your changes? |
I already using the latest one. Not sure what you are suggesting. Is that to npm install "nicolasritouet/dpd-fileupload#master" ? |
Great.
|
I plan to make a release soon (probably a pre 1.0.0 since a few people count on the stability and this release might have a breaking change, I need to review it) |
I just released an alpha version of 1.0.0. Once I have some feedback from the community, I'll release a final version. |
Great. Just installed and tested.
|
I tested yesterday evening quickly and I found a few issues (eg. rewrite of the config file breaks deployment on my test-app). I'll fix them and release again (still alpha). I'll also write a gist to help with migration. |
@NicolasRitouet any updates? Happy Holidays! |
Yes and no. |
regression with a fix to this issue here or with no fix?! |
Issue:
dpd-fileupload when used in a deployd project as dependency, breaks with an error if you try to use the deployd project with 'non server' application like grunt-dpdjs.
Cause :
These below lines are looking for process.server object to create the store location.
15 env = process.server.options && process.server.options.env || null,
25 this.store = process.server.createStore(this.name + "fileupload");
Any idea for a work around?
Here is the grun-dpdjs issue:
kechol/grunt-dpdjs#1
The text was updated successfully, but these errors were encountered: