Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpd-fileupload process.server.options (line 15) breaks when using grunt-dpdjs #72

Open
moorthi07 opened this issue Dec 6, 2016 · 10 comments

Comments

@moorthi07
Copy link

Issue:
dpd-fileupload when used in a deployd project as dependency, breaks with an error if you try to use the deployd project with 'non server' application like grunt-dpdjs.
Cause :
These below lines are looking for process.server object to create the store location.
15 env = process.server.options && process.server.options.env || null,
25 this.store = process.server.createStore(this.name + "fileupload");

Any idea for a work around?

Here is the grun-dpdjs issue:
kechol/grunt-dpdjs#1

@NicolasRitouet
Copy link
Owner

we have some changes that we haven't released yet that could solve your problem.
try to use this dependency instead of the default one:
"dpd-fileupload": "nicolasritouet/dpd-fileupload#master",

can you try and tell me if it solves your changes?

@moorthi07
Copy link
Author

I already using the latest one. Not sure what you are suggesting. Is that to npm install "nicolasritouet/dpd-fileupload#master" ?

@moorthi07
Copy link
Author

Great.

  1. It works - updating the package.json. Thanks.
  2. Doesn't install with direct npm install.
  3. Is it going to be in the next release? and How long to wait to get a semver to include in the project.

@NicolasRitouet
Copy link
Owner

I plan to make a release soon (probably a pre 1.0.0 since a few people count on the stability and this release might have a breaking change, I need to review it)

@NicolasRitouet
Copy link
Owner

I just released an alpha version of 1.0.0.
You can use it by using the next tag:
npm install dpd-fileupload@next --save

Once I have some feedback from the community, I'll release a final version.

@moorthi07
Copy link
Author

Great. Just installed and tested.

  1. Need document - to how to migrate from old version , especially how to set up the folder in the new version.
  2. 1.0 stores pictures in database directly - so that 'BREAKS' on reloading the picture from folder.
  3. This issue with 'non server packages' works fine.

@NicolasRitouet
Copy link
Owner

I tested yesterday evening quickly and I found a few issues (eg. rewrite of the config file breaks deployment on my test-app). I'll fix them and release again (still alpha). I'll also write a gist to help with migration.

@moorthi07
Copy link
Author

moorthi07 commented Dec 28, 2016

@NicolasRitouet any updates? Happy Holidays!

@NicolasRitouet
Copy link
Owner

Yes and no.
I tested a bit more (I'm not using deployd nor this plugin anymore, so it took a while) and what I didn't realized when I merged the PR to use the deployd collections is that the configuration tab in the dashboard doesn't exist anymore.
I don't know if you care about this or not, but it's definitively a regression :/

@moorthi07
Copy link
Author

regression with a fix to this issue here or with no fix?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants