Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ios not outputting frame N % 1001 #62

Open
SoylentGraham opened this issue Jun 15, 2022 · 2 comments
Open

ios not outputting frame N % 1001 #62

SoylentGraham opened this issue Jun 15, 2022 · 2 comments
Labels
Bug Something isn't working ios Redundant?

Comments

@SoylentGraham
Copy link
Member

From CR;

There seems to be a bug with PopH264 on iOS where frame 1001 does not produce a valid texture.
To help alleviate this, use modulus 999 to prevent the value that is sent through PopH264 from being above 1000
@SoylentGraham SoylentGraham added Bug Something isn't working ios labels Jun 15, 2022
@SoylentGraham
Copy link
Member Author

every video did this. If I remember correctly, this would also happen with frame 2002, 3003 ect.

@SoylentGraham
Copy link
Member Author

I think this is fixed, and there's an explicit integration test.
It was due to a float rounding error in the CF code.

Double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working ios Redundant?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SoylentGraham