Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider separate internal error code for MslTokenizer creation errors #161

Open
wmiaw opened this issue May 25, 2017 · 0 comments
Open
Assignees

Comments

@wmiaw
Copy link
Contributor

wmiaw commented May 25, 2017

MessageInputStream treats any MslEncoderException from MslEncoderFactory.createTokenizer(), MslTokenizer.more(), and the first call to MslTokenizer.nextObject() into a single internal error code of MslError.MSL_PARSE_ERROR.

It may be beneficial to separate out the tokenizer creation into a separate try/catch block to return a more specific MSL parsing error, similar to the one returned when the message data appears to be missing.

@wmiaw wmiaw self-assigned this Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant