Consider extending algorithms and cipher specs in MslConstants

[wmiaw]

Similar to how the authentication and keyx schemes can be extended by the MSL configuration layer, doing the same for the compression and crypto enums currently held in MslConstants will probably also be useful.

MslUtils would need to allow compression algorithms to be installed as well (maybe similar to Base64). Perhaps a compression class should be created explicitly to support compression implementations instead of continuing to mix it into MslUtils.

[quidryan]

Base64 was done on a global static level. It would be preferred to have compression algorithms configurable via an object instead of an static, something along the lines of MslContext (an object we provide to MSL).

[wmiaw]

The approach I've used is to use injection (e.g. MslContext) when there is context that needs to be carried for the operation, whereas standalone instances are global statics like Base64 and many other language library APIs, or like logging solutions.

I think compression would fall into the category of a standalone instance that could be used anywhere independent of context. Do you have an example of how Base64 would have benefited from being pulled off of MslContext? Doing so would also require passing MslContext into even more functions than it currently is provided to.