From a2934008e3976209673c5d1239fb2d5ea4924f91 Mon Sep 17 00:00:00 2001
From: kmg-stripe <kmg@stripe.com>
Date: Wed, 31 Jul 2024 16:10:22 -0700
Subject: [PATCH] Fix WorkersByJobId: Filtered Workers Not Empty Check (#699)

---
 .../persistence/KeyValueBasedPersistenceProvider.java     | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/server/master/persistence/KeyValueBasedPersistenceProvider.java b/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/server/master/persistence/KeyValueBasedPersistenceProvider.java
index 4e48f7a29..41a6dcd35 100644
--- a/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/server/master/persistence/KeyValueBasedPersistenceProvider.java
+++ b/mantis-control-plane/mantis-control-plane-server/src/main/java/io/mantisrx/server/master/persistence/KeyValueBasedPersistenceProvider.java
@@ -386,9 +386,11 @@ private Map<String, List<MantisWorkerMetadataWritable>> getAllWorkersByJobId(fin
                 })
                 .filter(Objects::nonNull)
                 .collect(Collectors.toList());
-            workersByJobId
-                .computeIfAbsent(workers.get(0).getJobId(), k -> Lists.newArrayList())
-                .addAll(workers);
+            if(!workers.isEmpty()) {
+                workersByJobId
+                    .computeIfAbsent(workers.get(0).getJobId(), k -> Lists.newArrayList())
+                    .addAll(workers);
+            }
         }
         return workersByJobId;
     }