Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor 1.2 build error #64

Open
rjsmith opened this issue Sep 23, 2015 · 8 comments
Open

Meteor 1.2 build error #64

rjsmith opened this issue Sep 23, 2015 · 8 comments

Comments

@rjsmith
Copy link

rjsmith commented Sep 23, 2015

Hi,
I am just trying to update my application to Meteor 1.2 and have hit a problem which I think I have tracked to the vicinity of the meteor-bootstrap package. After upgrading to Meteor 1.2, what seems to be happening is that meteor-bootstrap is still generating the custom.bootstrap.less and custom.bootstrap.mixins.import.less files (I deleted them locally to verify they were definitely being re-generated), but the new, re-written Meteor LESS processor can't find the generated files when importing the mixin file. Not sure if there is a timing issue (is the LESS processor running before nemo64:meteor-bootstrap?)

I am using the file structure suggested here:
www.manuel-schoebel.com/blog/meteorjs-and-twitter-bootstrap---the-right-way

=> Errors prevented startup:

   While processing files with less (for target web.browser):
   client/lib/stylesheets/style.less:2: Unknown import: /client/lib/stylesheets/vendor/custom.bootstrap.mixins.import.less
@emgee3
Copy link
Collaborator

emgee3 commented Sep 23, 2015

The package system got a major rewrite in Meteor 1.2 and should make some of the hacks needed to make meteor-bootstrap work unnecessary. That said, these same changes are backward incompatible for meteor-bootstrap at least, and I have not had a chance to look at the new changes yet.

Pull requests appreciated.

@patrickleet
Copy link

Anyone figured out an alternative to this package? Unfortunate that a package with 52k downloads is backwards incompatible.

@emgee3
Copy link
Collaborator

emgee3 commented Sep 30, 2015

I know it sucks it hasn't been updated for 1.2 yet, but the thing is I have been the only one maintaining and at the moment I don't really get to do any Meteor work at the job these days. As I said before pull requests are appreciated and I promise to review any promptly.

@perak
Copy link

perak commented Oct 12, 2015

👍

@emgee3
Copy link
Collaborator

emgee3 commented Oct 26, 2015

You can take a look at https://github.com/huttonr/bootstrap3

@andrecrt
Copy link

I had a similar symptom and, in my case, I found the solution in https://quip.com/RXFlAk9Rc2xI

"... Use @import "{}/file.import.less" to load a file from your app ..."

Does this work for you? @rjsmith

@petr-kalinin
Copy link

@andreftavares, thanks, I had the same problem and you solution worked.

Slightly more elaborated: use something like

 @import "{}/client/lib/stylesheets/vendor/custom.bootstrap.mixins.import.less"

@rjsmith
Copy link
Author

rjsmith commented Nov 14, 2015

Hi @andreftavares https://github.com/andreftavares, I finally got to
trying your workround, and yes, it does seem to work, thanks.

On 14 November 2015 at 14:11, Petr Kalinin [email protected] wrote:

@andreftavares https://github.com/andreftavares, thanks, I had the same
problem and you solution worked.

Slightly more elaborated: use something like

@import "{}/client/lib/stylesheets/vendor/custom.bootstrap.mixins.import.less"


Reply to this email directly or view it on GitHub
#64 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants