-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source map #36
Comments
Same happened to me, too - i also wonder if this package will be updated to the lastest bootstrap version anytime soon or if it's probably a better idea to fork it. |
@Helmi instead of forking, shouldn't you consider to do a pull request? |
I think this is actually a bug in the meteor core. What seems to happen is that source maps get a bit messed up when the css files are concatenated and more than one package uses a similar source map path. See meteor/meteor#3304 (comment) (last comment) If you're using I find that if you remove the |
@simison I'm happy to do the update to this library and issue a pull request. Do we know if this is still an active project? Just asking because I saw a few pull requests in there unaddressed and it appears there's not been much activity in the last few months. (Although this is a wonderful, pretty much bug free package so I can see why. 👍 ) |
@webkenny I think you're right: this package isn't regularly maintained. But as you say, it works perfectly so it's understandable. |
See #30 (comment) @Nemo64 perhaps you could open a call for maintainers and add them as contributors? |
It would help. What do you mean by "a call for maintainers"? I'm a little inexperienced with managing repositories. I'd gladly take help maintaining this package. |
Hi @Nemo64. Great work on this package. @simison means putting inside your README.md that you are looking for co-maintainers of the package and allowing them to have contribute access to help you with pull requests and general maintenance. I know, for one, I'd be more than willing to assist. In the meantime, I'll go ahead and update Bootstrap to 3.3.2 and issue a pull for it. |
Hey all, I'm helping maintain this now. Ping me if you need a PR looked at. In the meantime, since this looks like a Meteor bug, I'm going to close this. |
Thanks for this great package. My source map happens to be off. The line numbers are wrong. I'm not sure if it's a bug or if I'm missing something obvious. Any thoughts?
Thanks!
db
The text was updated successfully, but these errors were encountered: