Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source map #36

Closed
huevoncito opened this issue Jan 28, 2015 · 9 comments
Closed

Source map #36

huevoncito opened this issue Jan 28, 2015 · 9 comments

Comments

@huevoncito
Copy link

Thanks for this great package. My source map happens to be off. The line numbers are wrong. I'm not sure if it's a bug or if I'm missing something obvious. Any thoughts?

Thanks!
db

@Helmi
Copy link

Helmi commented Jan 30, 2015

Same happened to me, too - i also wonder if this package will be updated to the lastest bootstrap version anytime soon or if it's probably a better idea to fork it.

@simison
Copy link
Contributor

simison commented Jan 30, 2015

@Helmi instead of forking, shouldn't you consider to do a pull request?

@huevoncito
Copy link
Author

I think this is actually a bug in the meteor core. What seems to happen is that source maps get a bit messed up when the css files are concatenated and more than one package uses a similar source map path. See meteor/meteor#3304 (comment) (last comment) If you're using @include in any of your stylesheets, that will force a concatenation and trigger the bug.

I find that if you remove the @include statements, it works properly. That's a huge pain and sort of defeats the point of less, but that's where we're at right now.

@webkenny
Copy link

webkenny commented Feb 4, 2015

@simison I'm happy to do the update to this library and issue a pull request. Do we know if this is still an active project?

Just asking because I saw a few pull requests in there unaddressed and it appears there's not been much activity in the last few months. (Although this is a wonderful, pretty much bug free package so I can see why. 👍 )

@huevoncito
Copy link
Author

@webkenny I think you're right: this package isn't regularly maintained. But as you say, it works perfectly so it's understandable.

@simison
Copy link
Contributor

simison commented Feb 4, 2015

See #30 (comment)

@Nemo64 perhaps you could open a call for maintainers and add them as contributors?

@Nemo64
Copy link
Owner

Nemo64 commented Feb 4, 2015

It would help. What do you mean by "a call for maintainers"? I'm a little inexperienced with managing repositories. I'd gladly take help maintaining this package.

@webkenny
Copy link

webkenny commented Feb 5, 2015

Hi @Nemo64. Great work on this package. @simison means putting inside your README.md that you are looking for co-maintainers of the package and allowing them to have contribute access to help you with pull requests and general maintenance. I know, for one, I'd be more than willing to assist. In the meantime, I'll go ahead and update Bootstrap to 3.3.2 and issue a pull for it.

@emgee3
Copy link
Collaborator

emgee3 commented Mar 31, 2015

Hey all, I'm helping maintain this now. Ping me if you need a PR looked at. In the meantime, since this looks like a Meteor bug, I'm going to close this.

@emgee3 emgee3 closed this as completed Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants