Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to filter licenses by top-level project features #87

Open
jwodder opened this issue Oct 27, 2023 · 2 comments
Open

Add option to filter licenses by top-level project features #87

jwodder opened this issue Oct 27, 2023 · 2 comments

Comments

@jwodder
Copy link

jwodder commented Oct 27, 2023

Currently, cargo-lichking determines the packages to bundle licenses for by evaluating the dependency tree for the top-level project with its default features selected. However, it may happen that a developer wants to distribute binaries built with a non-default feature selection (instead of or in addition to binaries with default features), and so they would need a license bundle that reflects the dependencies added & removed by the change in features, but cargo-lichking does not provide that.

I therefore request the ability to specify a set of features to apply when determining a project's dependencies.

@Nemo157
Copy link
Owner

Nemo157 commented Oct 27, 2023

@jwodder before you get too deep in with cargo-lichking, I should mention I've been meaning to explicitly deprecate it for a while. There are other existing tools that cover most of its functionality better.

@jwodder
Copy link
Author

jwodder commented Oct 27, 2023

@Nemo157 I figured it was inactive. I'm not actually going to use cargo-lichking; I'm writing up a comparison of Rust license-bundling programs, which means judging the quality of each one, and I'd be remiss if I didn't file issues for the problems I found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants