Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart Unable to Prevent MPS DaemonSet Deployment #1177

Open
marinoborges opened this issue Feb 25, 2025 · 2 comments · May be fixed by #1178
Open

Helm Chart Unable to Prevent MPS DaemonSet Deployment #1177

marinoborges opened this issue Feb 25, 2025 · 2 comments · May be fixed by #1178

Comments

@marinoborges
Copy link

Problem description:
Currently there's no way for a helm chart user to disable deploying MPS DaemonSet deployment without having to disable devicePlugin.enabled which affects both MPS & device-plugin DaemonSet.

Desired solution:
Be able to disable MPS DaemonSet without affecting device-plugin DaemonSet.
@klueska
Copy link
Contributor

klueska commented Feb 25, 2025

The MPS daemonset is always deployed. However, it doesn't actually launch an MPS server unless you configure it to. It is just sitting there waiting for a (re)configuration to trigger it to do something.

@marinoborges marinoborges linked a pull request Feb 25, 2025 that will close this issue
Open
@chipzoller
Copy link
Contributor

It'd be nice to hear a problem statement here. Why is deploying the MPS DaemonSet with no replicas until MPS is activated a problem that needs a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] [HELM] Add support to disable MPS marinoborges/k8s-device-plugin
3 participants
@klueska @chipzoller @marinoborges