Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor & rename the /admin/slack/create-proposal-channel/{proposal_id} endpoint #81

Open
stuartcampbell opened this issue May 17, 2024 · 2 comments
Open

Refactor & rename the /admin/slack/create-proposal-channel/{proposal_id} endpoint #81

stuartcampbell opened this issue May 17, 2024 · 2 comments
Assignees
@stuartcampbell
Labels
enhancement New feature or request

Comments

@stuartcampbell
Copy link
Collaborator

Instead of having the existing endpoint that will create (and update if the channel already exists), have a single endpoint name that we call using the different HTTP verbs, so that

  • GET - returns information on a proposal slack channel
  • POST - creates a proposal slack channel - errors if already exists
  • PUT - updates / enforces settings for an existing proposal slack channel

@danielballan @padraic-shafer Does this make sense ?
@stuartcampbell stuartcampbell added the enhancement New feature or request label May 17, 2024
@stuartcampbell stuartcampbell self-assigned this May 17, 2024
@stuartcampbell stuartcampbell mentioned this issue May 17, 2024
Merged
@padraic-shafer
Copy link
Collaborator

padraic-shafer commented May 17, 2024 •
edited
Loading

This sounds good to me.

@stuartcampbell
Copy link
Collaborator Author

Do we also want a DELETE ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartcampbell stuartcampbell

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuartcampbell @padraic-shafer