Add facility query param for commissioning proposals #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR depends on #139 (the facility field must exist in Proposal) |
JunAishima
approved these changes
Jan 31, 2025
| ) | ||
| else: | ||
| proposals = Proposal.find( | ||
| Proposal.pass_type_id == "300005", projection_model=ProposalIdView | ||
| proposals = await Proposal.find(And(*query)).find( |
There was a problem hiding this comment.
Any reason why the projection was dropped ?
There was a problem hiding this comment.
It wasn't dropped, there was no projection used when filtering results before: - I kept it the same as I was unsure if there was a reason for this. That said, it seems to me that we could add it in the final find op.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140