Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laboratory prototype missing fume hood exhaust fans #1278

Closed
eringold opened this issue Mar 8, 2022 · 4 comments
Closed

Laboratory prototype missing fume hood exhaust fans #1278

eringold opened this issue Mar 8, 2022 · 4 comments
Labels
OS Prototypes Improvements to the OS prototype models.

Comments

@eringold
Copy link
Collaborator

eringold commented Mar 8, 2022

Marked as todo and stubbed out here:

# @todo add exhaust fan to fume hood zone
# search_criteria = ...
# fume_hood_space = model_find_object(standards_data['Space Types'], search_criteria)
# fume_hood_zone_volume = fume_hood_space.getVolume...
# flow_rate_fume_hood = fume_hood_zone_volume * fume_hood_space['Ventilation_Air_Changes...']
# model_add_exhaust_fan(model, thermal_zones, flow_rate=flow_rate_fume_hood, flow_fraction_schedule_name='Lab_FumeHood_Sch')

@mdahlhausen
Copy link
Collaborator

@KaiyuSun any thoughts on how we should address this?

@KaiyuSun
Copy link
Collaborator

@eringold Thanks for catching the leftover TODO item!
@mdahlhausen I'll work on it next week and let you know when I'm finished.

@KaiyuSun
Copy link
Collaborator

KaiyuSun commented Mar 18, 2022

@mdahlhausen @eringold Just pushed the updated codes, check it out #1287 (comment)

Besides, I found a potential issue with the zone exhaust fan efficiency and posted here, could you help examine as well?

@mdahlhausen mdahlhausen added the OS Prototypes Improvements to the OS prototype models. label Mar 29, 2022
@mdahlhausen
Copy link
Collaborator

Addressed with #1287, though there is still an issue with the exhaust fan efficiency as detailed in #1286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS Prototypes Improvements to the OS prototype models.
Projects
None yet
Development

No branches or pull requests

3 participants