-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out how to use a path split with more than 2 options #208
Comments
Search for self.split_dict |
Updates issue branch for #208 with recent commits
Porting over comment from closed related PR: With the fairly large caveat that I haven't tested this on a data version with the multiple-facility-split feature, I'm not sure this logic will work. The I've annotated the current logic below for context. I think the most efficient solution would be to refactor (Side note: An alternate implementation here would be to use the loss fraction as the probability on a Boolean random variable, and making it so instead of 10% of each component going to landfill, 10% of whole components go to landfill and the rest continue as is. This might be an adjustment to make in the future and would help to capture e.g. window breakage during installation with a little more specificity.) ETA: I think heading toward a stochastic, whole-component split would make way more sense for the glass case study. I'm going to create a related issue (#225 ) to implement this functionality with the option to either lose a mass fraction or proportion of whole components, depending on the facility type. For this issue Keep the current functionality that only uses mass fractions (of whole components) to implement path splitting.
|
…h to specific facility type; helps in #208
See related data and YAML updates in data repo commits: 1ea4b795bb556d10be4a7e9592a952414c426668 656ddf510a3becccc92901cfd3b9d719c1c75265 a6e22342f9fd80871a515e90ecdb865a9d45b79a |
Look into the "path_split" function in the component.py.
The text was updated successfully, but these errors were encountered: