Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove REPLAY_ICS and other related variables from develop #3305

Open
EricSinsky-NOAA opened this issue Feb 5, 2025 · 0 comments
Open

Remove REPLAY_ICS and other related variables from develop #3305

EricSinsky-NOAA opened this issue Feb 5, 2025 · 0 comments
Labels
bug Something isn't working triage Issues that are triage

Comments

@EricSinsky-NOAA
Copy link
Contributor

What is wrong?

The REPLAY_ICS conditionals in the develop branch are adding unnecessary complexity to the global-workflow. The REPLAY_ICS variable is needed for the GEFS reforecast, but since the GEFS reforecast now has its own branch, there is no need to keep the REPLAY_ICS and other similar variables related to replay ICs in the develop branch.

What should have happened?

The REPLAY_ICS and other similar variables should be removed from the develop branch to reduce any unnecessary complexities in the global-workflow related to replay ICs.

What machines are impacted?

All or N/A

What global-workflow hash are you using?

3d6c13e

Steps to reproduce

  1. Set up any global-workflow experiment and run any experiment.
  2. The workflow will likely have to go through REPLAY_ICS conditional statements during the experiment set up and run. This can contribute to more lengthy log files and consequently more difficult debugging.

Additional information

No response

Do you have a proposed solution?

Remove REPLAY_ICS variables from all relevant scripts. Also, remove any files that are only used when REPLAY_ICS is set (e.g. diag_table_replay). The replay IC CI test may no longer be needed either.

@EricSinsky-NOAA EricSinsky-NOAA added bug Something isn't working triage Issues that are triage labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issues that are triage
Projects
None yet
Development

No branches or pull requests

1 participant