-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume slicing: Remove subsetting and put more emphasis on anisotropy #613
Comments
Yes sounds good! I can also help if needed as I think I worked on part of this one before. |
Thanks @AnniekStok! I think the fastest is if I just do something and then ask you to review it. |
@AnniekStok I tried to modify the figure but the powerpoint drawings are not editable. ![]() Do you have an editable version of this? E.g.,
|
I believe @stemarcotti created this figure, and put the pptx file here: https://github.com/NEUBIAS/training-resources/files/7896791/20220118_slicing.pptx Adding random numbers would make it clear that those pixels are not really empty, but that we just focus on the colored ones. I think the rotation was there to make it clear that you have to rotate the image to see it on the 2D screen. Maybe we can visualize that somehow? For anisotropic voxels, maybe we can just use elongated rectangles instead? E.g. (raw sketch): But we would have to make clear somehow that the rectangles are always visualized as squares, so that what you see on your screen appears 'squished'. |
Thanks! The PPT you found is editable! I will copy this into the I simplified the figure now: ![]() In BDV they are not squished, but rendered exactly as you depicted it. ![]() So maybe, we could just have the above figure that @stemarcotti created but with anisotropic voxels? Then we would need only one drawing to show everything? |
In your sketch, I would rather elongate along the axis that runs from top to bottom...as I would find it more intuitive that that is the z-axis... |
Ok, sounds good! I can quickly remake it to have one like the updated one from @stemarcotti you just showed but with elongated voxels vertically? |
Thanks, that would be great! Are you using PPT? This would be important for compatibility. |
Illustrator, but the shapes are pastable in powerpoint so I can convert it for compatibility. |
This one should be editable (maybe we want to remove the 3d shapes in between and only show the flat one): |
Thanks! Yeah, let's remove the shapes in-between. And could you make all the voxel size number letters the same size? I think it would look more beautiful. |
volume_slicing.pptx like this? |
yes I can fix it |
@AnniekStok sorry, the image dimensions (2,4) and (2,3) are missing in the slices; it turns out adding them in PPT is very painful, because, e.g., the arrows are not one object, but several. Could you maybe do the image dimensions in PPT? In general, I think the more of this is done in PPT the easier will it be for future contributors to to further work on this. |
volume_slicing.pptx |
Thanks! I think now it is good! |
Could you please review this module: https://neubias.github.io/training-resources/volume_slicing/index.html |
Yes I can, you made the changes directly in the master branch, right? I made a new branch with pull request here: I think a python activity slicing in numpy arrays could be nice? Instead of / in addition to the jython one? |
Of course, do you feel like adding it? You could take some of the other python code in other modules as templates. |
Yes I can, though not right away since this week is a bit busy. How about a python-napari-gui and a python-napari version (similar to imagej-gui and imagej-macro)? |
I am closing this issue now, because it has been refactored, but of course feel invited to still add some python implementations :-) |
A bit late but I have added a proposal for a python-napari implementation in the pull request here: #630 |
Hi @AnniekStok @manerotoni @maulakhan @tibuch @grinic et al.,
Would it be OK for you if, for the volume slicing module, I would
I think this DNA metaphase plate would be a quite nice example image:
from: https://pubmed.ncbi.nlm.nih.gov/34787651/
What do you think?
The text was updated successfully, but these errors were encountered: