Pin numpy version to avoid bug which impacts array ordering #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erogluorhan
reviewed
Jun 16, 2023
Thanks for catching these! I will be looking out for them and helping out if needed |
erogluorhan
approved these changes
Jun 16, 2023
|
Confirmed the tests pass on 1.25.0rc1 so I'm going to leave this with just the negation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin numpy version (!= 1.24.3) to avoid bug which impacts array ordering in requirements and conda build envs.
I also removed the conda_recipe directory rather than updating the meta.yml in there since that content now lives in the feedstock repo and seems to be duplicative and a bit out of date.
Relatedly, this change will also need to be made in the wrf-python conda-forge feedstock repo. I'll log an issue there and can submit a PR, but that one might need a closer look.
While looking into this issue, I also noticed our testing doesn't appear to be keeping up with the versions we're releasing on conda-forge (i.e. it looks like we're only testing Python 3.10 w/ through CI, but doing Python 3.11 releases). I'll log an issue to update testing as well.
Closes #207.