Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration routines for third party packages (enable_*(), disable_*(), *_enabled()) do not work #168

Closed
sfalmo opened this issue Apr 6, 2022 · 1 comment · Fixed by #169

Comments

@sfalmo
Copy link
Contributor

sfalmo commented Apr 6, 2022

By default, wrf-python checks if a useful third party package such as xarray, cartopy, basemap or PyNGL is installed and uses it in this case. Additionally, there are some configuration routines (https://wrf-python.readthedocs.io/en/latest/user_api/index.html#configuration-routines) for enabling or disabling those third party packages regardless of the default behavior.

These configuration routines do not work. For example,

import wrf

wrf.disable_xarray()
print(wrf.xarray_enabled())

prints True if xarray is installed and subsequent calls to wrf.getvar still return xarrays.

@michaelavs
Copy link
Contributor

Hi @sfalmo,
Thank you for opening this issue and a corresponding PR! I will be reviewing the PR in the next week to make sure everything runs smoothly before approval. Once approved, we can merge and release the fix for wrf-python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants