Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARCStreamTransform can experience ERR_MULTIPLE_CALLBACK error #57

Open
cmawhorter opened this issue Feb 6, 2023 · 2 comments
Open

Comments

@cmawhorter
Copy link

_flush (done) {
if (this.buffered) {
this._consumeChunk(this.buffered, done, true)
}
done()
}

since _consumeChunk calls done, i think this should be:

  _flush (done) {
    if (this.buffered) {
      this._consumeChunk(this.buffered, done, true)
    } else {
      done()
    }
  }
@efrazier
Copy link

efrazier commented May 26, 2023

Hey, I just made this change because I ran into the exact error you are talking about. I was using their stream demo code and this fixed it.

@samheutmaker
Copy link

It looks like this repo is no longer maintained. I published a fork with this fix here, NPM package here.

npm install --save @context-labs/node-warc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants